From: Michael Walle <michael@walle.cc>
To: Sameer Pujar <spujar@nvidia.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, oder_chiou@realtek.com,
jonathanh@nvidia.com, kuninori.morimoto.gx@renesas.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
sharadg@nvidia.com
Subject: Re: [PATCH 1/2] ASoC: simple-card-utils: Do not handle device clock
Date: Mon, 15 Mar 2021 18:39:31 +0100 [thread overview]
Message-ID: <62f003b9cf2bc1ae238689ea811b870d@walle.cc> (raw)
In-Reply-To: <1615829492-8972-2-git-send-email-spujar@nvidia.com>
Am 2021-03-15 18:31, schrieb Sameer Pujar:
> This reverts commit 1e30f642cf29 ("ASoC: simple-card-utils: Fix device
> module clock"). The original patch ended up breaking following
> platform,
> which depends on set_sysclk() to configure internal PLL on wm8904 codec
> and expects simple-card-utils to not update the MCLK rate.
> -
> "arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts"
>
> It would be best if codec takes care of setting MCLK clock via DAI
> set_sysclk() callback.
>
> Reported-by: Michael Walle <michael@walle.cc>
> Suggested-by: Mark Brown <broonie@kernel.org>
> Suggested-by: Michael Walle <michael@walle.cc>
> Fixes: 1e30f642cf29 ("ASoC: simple-card-utils: Fix device module
> clock")
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Thanks!
Tested-by: Michael Walle <michael@walle.cc>
-michael
next prev parent reply other threads:[~2021-03-15 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 17:31 [PATCH 0/2] Do not handle MCLK device clock in simple-card-utils Sameer Pujar
2021-03-15 17:31 ` [PATCH 1/2] ASoC: simple-card-utils: Do not handle device clock Sameer Pujar
2021-03-15 17:39 ` Michael Walle [this message]
2021-03-15 17:31 ` [PATCH 2/2] ASoC: rt5659: Update MCLK rate in set_sysclk() Sameer Pujar
2021-03-15 18:03 ` [PATCH 0/2] Do not handle MCLK device clock in simple-card-utils Mark Brown
2021-03-16 17:59 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62f003b9cf2bc1ae238689ea811b870d@walle.cc \
--to=michael@walle.cc \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox