public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Olof Johansson <olof@lixom.net>,
	linux-tegra@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 12/12] ARM: tegra: Convert PMC to a driver
Date: Wed, 16 Jul 2014 17:22:03 +0200	[thread overview]
Message-ID: <6322144.IB6iKDb6TK@wuerfel> (raw)
In-Reply-To: <20140716151427.GA22027@ulmo>

On Wednesday 16 July 2014 17:14:29 Thierry Reding wrote:
> > 
> > Ok, I'll have a look. I think when this becomes a separate driver, it
> > should also have its own header file, so maybe you can in the meantime
> > make it a local header file in mach-tegra until we have found a good
> > place for it.
> 
> Why do you think it should be a separate header? We already have a
> couple in include/linux and I'm not sure it's useful to add even more.
> If anything I would've thought it made sense to move the content of the
> other headers into tegra-soc.h.

I very much dislike the idea of having a per-vendor header file that
everything gets crammed into. We should try to have proper subsystems
and generic interfaces for these wherever possible.

	Arnd

  reply	other threads:[~2014-07-16 15:22 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 12:15 [PATCH 00/12] Add NVIDIA Tegra FUSE driver Thierry Reding
2014-07-11 12:16 ` [PATCH 02/12] ARM: tegra: Use a function to get the chip ID Thierry Reding
     [not found] ` <1405080971-7609-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-11 12:16   ` [PATCH 01/12] ARM: tegra: Sort includes alphabetically Thierry Reding
2014-07-11 12:16   ` [PATCH 03/12] ARM: tegra: export apb dma readl/writel Thierry Reding
2014-07-11 12:16   ` [PATCH 04/12] ARM: tegra: move fuse exports to tegra-soc.h Thierry Reding
2014-07-11 12:16   ` [PATCH 06/12] soc/tegra: Add efuse and apbmisc bindings Thierry Reding
2014-07-11 12:16   ` [PATCH 07/12] soc/tegra: fuse: move APB DMA into Tegra20 fuse driver Thierry Reding
2014-07-11 12:16   ` [PATCH 08/12] misc: fuse: fix dummy functions Thierry Reding
2014-07-11 12:16   ` [PATCH 09/12] ARM: tegra: Setup CPU hotplug in a pure initcall Thierry Reding
2014-07-11 12:16   ` [PATCH 10/12] ARM: tegra: Always lock the CPU reset vector Thierry Reding
2014-07-11 12:16   ` [PATCH 11/12] soc/tegra: fuse: Set up in early initcall Thierry Reding
2014-07-11 12:16   ` [PATCH 12/12] ARM: tegra: Convert PMC to a driver Thierry Reding
     [not found]     ` <1405080971-7609-13-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-11 13:58       ` Peter De Schrijver
     [not found]         ` <20140711135800.GD23218-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-07-14  8:06           ` Thierry Reding
2014-07-16 11:56       ` Arnd Bergmann
     [not found]         ` <201407161356.44693.arnd-r2nGTMty4D4@public.gmane.org>
2014-07-16 13:22           ` Thierry Reding
2014-07-16 14:12             ` Arnd Bergmann
2014-07-16 15:14               ` Thierry Reding
2014-07-16 15:22                 ` Arnd Bergmann [this message]
2014-07-16 18:57                   ` Thierry Reding
2014-07-16 19:34                     ` Olof Johansson
     [not found]                       ` <CAOesGMi=UrLS3OuFb9SAaf9dPBojYrqp4VE0YhGiX1hkLvYanw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-17  8:54                         ` Arnd Bergmann
2014-07-17 11:06                           ` Thierry Reding
2014-07-21 12:06                             ` Arnd Bergmann
2014-07-21 13:12                               ` Thierry Reding
2014-07-21 13:16                                 ` Tejun Heo
     [not found]                                   ` <20140721131619.GE12921-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-07-21 13:39                                     ` Thierry Reding
2014-07-17  8:53                     ` Peter De Schrijver
2014-07-17  9:01                       ` Peter De Schrijver
     [not found]                         ` <20140717090156.GR23218-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-07-17 11:01                           ` Thierry Reding
2014-07-21  7:09                             ` Vince Hsu
     [not found]                               ` <53CCBCA9.7020907-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-07-21  9:02                                 ` Thierry Reding
2014-07-22  3:34                                   ` Vince Hsu
2014-07-13  6:38   ` [PATCH 00/12] Add NVIDIA Tegra FUSE driver Olof Johansson
     [not found]     ` <20140713063815.GA24843-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2014-07-14  6:57       ` Thierry Reding
2014-07-11 12:16 ` [PATCH 05/12] soc/tegra: Add efuse driver for Tegra Thierry Reding
     [not found]   ` <1405080971-7609-6-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-19  3:12     ` Shawn Guo
2014-11-10 15:10       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6322144.IB6iKDb6TK@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox