From: Dmitry Osipenko <digetx@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Cc: leonard.crestez@nxp.com, lukasz.luba@arm.com,
enric.balletbo@collabora.com, hl@rock-chips.com,
thierry.reding@gmail.com, jonathanh@nvidia.com,
abel.vesa@nxp.com, k.konieczny@samsung.com,
b.zolnierkie@samsung.com, chanwoo@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH v3 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes
Date: Mon, 19 Oct 2020 03:38:29 +0300 [thread overview]
Message-ID: <63ac80e9-7f31-8447-06ca-e7d830a4aed4@gmail.com> (raw)
In-Reply-To: <20201007050703.20759-3-cw00.choi@samsung.com>
...
> diff --git a/Documentation/ABI/testing/sysfs-class-devfreq b/Documentation/ABI/testing/sysfs-class-devfreq
> index deefffb3bbe4..67af3f31e17c 100644
> --- a/Documentation/ABI/testing/sysfs-class-devfreq
> +++ b/Documentation/ABI/testing/sysfs-class-devfreq
> @@ -37,20 +37,6 @@ Description:
> The /sys/class/devfreq/.../target_freq shows the next governor
> predicted target frequency of the corresponding devfreq object.
>
> -What: /sys/class/devfreq/.../polling_interval
> -Date: September 2011
> -Contact: MyungJoo Ham <myungjoo.ham@samsung.com>
> -Description:
> - The /sys/class/devfreq/.../polling_interval shows and sets
> - the requested polling interval of the corresponding devfreq
> - object. The values are represented in ms. If the value is
> - less than 1 jiffy, it is considered to be 0, which means
> - no polling. This value is meaningless if the governor is
> - not polling; thus. If the governor is not using
> - devfreq-provided central polling
> - (/sys/class/devfreq/.../central_polling is 0), this value
> - may be useless.
> -
> What: /sys/class/devfreq/.../trans_stat
> Date: October 2012
> Contact: MyungJoo Ham <myungjoo.ham@samsung.com>
> @@ -65,14 +51,6 @@ Description:
> as following:
> echo 0 > /sys/class/devfreq/.../trans_stat
>
> -What: /sys/class/devfreq/.../userspace/set_freq
> -Date: September 2011
> -Contact: MyungJoo Ham <myungjoo.ham@samsung.com>
> -Description:
> - The /sys/class/devfreq/.../userspace/set_freq shows and
> - sets the requested frequency for the devfreq object if
> - userspace governor is in effect.
> -
> What: /sys/class/devfreq/.../available_frequencies
> Date: October 2012
> Contact: Nishanth Menon <nm@ti.com>
> @@ -109,6 +87,35 @@ Description:
> The max_freq overrides min_freq because max_freq may be
> used to throttle devices to avoid overheating.
>
> +What: /sys/class/devfreq/.../polling_interval
> +Date: September 2011
> +Contact: MyungJoo Ham <myungjoo.ham@samsung.com>
> +Description:
> + The /sys/class/devfreq/.../polling_interval shows and sets
> + the requested polling interval of the corresponding devfreq
> + object. The values are represented in ms. If the value is
> + less than 1 jiffy, it is considered to be 0, which means
> + no polling. This value is meaningless if the governor is
> + not polling; thus. If the governor is not using
> + devfreq-provided central polling
> + (/sys/class/devfreq/.../central_polling is 0), this value
> + may be useless.
> +
> + A list of governors that support the node:
> + - simple_ondmenad
> + - tegra_actmon
> +
> +What: /sys/class/devfreq/.../userspace/set_freq
> +Date: September 2011
> +Contact: MyungJoo Ham <myungjoo.ham@samsung.com>
> +Description:
> + The /sys/class/devfreq/.../userspace/set_freq shows and
> + sets the requested frequency for the devfreq object if
> + userspace governor is in effect.
> +
> + A list of governors that support the node:
> + - userspace
> +
> What: /sys/class/devfreq/.../timer
> Date: July 2020
> Contact: Chanwoo Choi <cw00.choi@samsung.com>
> @@ -120,3 +127,6 @@ Description:
> as following:
> echo deferrable > /sys/class/devfreq/.../timer
> echo delayed > /sys/class/devfreq/.../timer
> +
> + A list of governors that support the node:
> + - simple_ondemand
Hello, Chanwoo!
Could you please explain the reason of changing the doc? It looks like
you only added the lists of governors, but is it a really useful change?
Are you going to keep these lists up-to-date?
next prev parent reply other threads:[~2020-10-19 0:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201007045340epcas1p32326a90323a3313f39041e3699e477f0@epcas1p3.samsung.com>
2020-10-07 5:07 ` [PATCH v3 0/2] PM / devfreq: Add governor feature and attribute flag Chanwoo Choi
2020-10-07 5:07 ` [PATCH v3 1/2] PM / devfreq: Add governor feature flag Chanwoo Choi
2020-10-19 0:57 ` Dmitry Osipenko
2020-10-19 3:53 ` Chanwoo Choi
2020-10-19 22:39 ` Dmitry Osipenko
2020-10-20 1:53 ` Chanwoo Choi
2020-10-07 5:07 ` [PATCH v3 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes Chanwoo Choi
2020-10-19 0:38 ` Dmitry Osipenko [this message]
2020-10-19 3:55 ` Chanwoo Choi
2020-10-19 0:39 ` Dmitry Osipenko
2020-10-19 4:11 ` Chanwoo Choi
2020-10-19 10:41 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ac80e9-7f31-8447-06ca-e7d830a4aed4@gmail.com \
--to=digetx@gmail.com \
--cc=abel.vesa@nxp.com \
--cc=b.zolnierkie@samsung.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=enric.balletbo@collabora.com \
--cc=hl@rock-chips.com \
--cc=jonathanh@nvidia.com \
--cc=k.konieczny@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox