From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Chew Subject: RE: [PATCH V4 6/9] ARM: mxs: Provide regulator to pwm-backlight Date: Tue, 19 Mar 2013 14:31:34 -0700 Message-ID: <643E69AA4436674C8F39DCC2C05F7638629CD2FDF4@HQMAIL03.nvidia.com> References: <1363719573-20926-1-git-send-email-achew@nvidia.com> <1363719573-20926-7-git-send-email-achew@nvidia.com> <201303192227.21717.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201303192227.21717.marex@denx.de> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marek Vasut Cc: "romain.naour@openwide.fr" , "thierry.reding@avionic-design.de" , "philipp.zabel@gmail.com" , "gxt@mprc.pku.edu.cn" , "robert.jarzmik@free.fr" , "laforge@openezx.org" , "openezx-devel@lists.openezx.org" , "linux@arm.linux.org.uk" , "linux-samsung-soc@vger.kernel.org" , "lost.distance@yahoo.com" , "drwyrm@gmail.com" , "swarren@wwwdotorg.org" , "haojian.zhuang@gmail.com" , "kgene.kim@samsung.com" , Alex Courbot , "linux-tegra@vger.kernel.org" , linux-arm-kernel@lists.i List-Id: linux-tegra@vger.kernel.org > Dear Andrew Chew, > > > The pwm-backlight driver now takes a mandatory regulator that is > > gotten during driver probe. Initialize a dummy regulator to satisfy > > this requirement. > > > > Signed-off-by: Andrew Chew > > Do we really need a mandatory regulator? Why can't it be optional? > > Best regards, > Marek Vasut Because for those using board setup code (and not devicetree), it was not possible to distinguish between opting out of the regulator, and deferred probe, without adding something to the platform data that board setup code needed to fill in anyway.