From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A9BCC7113C for ; Fri, 18 Aug 2023 03:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357586AbjHRD1v (ORCPT ); Thu, 17 Aug 2023 23:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357606AbjHRD12 (ORCPT ); Thu, 17 Aug 2023 23:27:28 -0400 Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394153A95; Thu, 17 Aug 2023 20:27:22 -0700 (PDT) Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTP id WcMGqbqmREoVsWq8vqImxy; Fri, 18 Aug 2023 03:27:21 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id Wq8uq9iYVHSofWq8uq2vsX; Fri, 18 Aug 2023 03:27:21 +0000 X-Authority-Analysis: v=2.4 cv=HbEH8wI8 c=1 sm=1 tr=0 ts=64dee519 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=UttIx32zK-AA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=Ikd4Dj_1AAAA:8 a=pGLkceISAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XbHhoaMV1A5PFRjmbPAVWbKEqbP19+yPSsLA0Z9QwNQ=; b=wPrYo/FoqPKaYfGL2zf96uXJeD 18FoakBijHKvCCo3zew1dfLaIjkuW2o30kWz7/h2sRbH3RwMTbgolAtsfDQIzSjLxObRXOT5UzRjX vCuiW+QQESjAhHsqxKBlw69nW+jU7FfBaMX/5XZFbyg7NIaapSlfQLvpPIMyx/vi5wKtO8PQpITcH zc4u3e4hqQx7OmnzJaXL7vOSG+/R4AOoRTmYjJAR1H8IIlPdVVb/x9sRglj6ceUlieZmeDRlkuuzb itrGcpna0kW51LuudgGi8H1s72NJDWCJIFFz/HX21wOlSnwidan16EzrjUBnz4Y8jqaeTFJjVVIPl VftOMYFQ==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:60186 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qWp0B-001BiV-3A; Thu, 17 Aug 2023 21:14:16 -0500 Message-ID: <669608a3-407a-91b6-7bdc-92a0f5670d5f@embeddedor.com> Date: Thu, 17 Aug 2023 20:15:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 16/21] dmaengine: tegra210-adma: Annotate struct tegra_adma with __counted_by Content-Language: en-US To: Kees Cook , Vinod Koul Cc: Laxman Dewangan , Jon Hunter , Thierry Reding , dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, Hector Martin , Sven Peter , Alyssa Rosenzweig , Ludovic Desroches , Tudor Ambarus , Lars-Peter Clausen , Zhou Wang , Jie Hai , Andy Gross , Bjorn Andersson , Konrad Dybcio , Green Wan , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Peter Ujfalusi , Kunihiko Hayashi , Masami Hiramatsu , Yu Kuai , Greg Kroah-Hartman , Jordy Zomer , Jernej Skrabec , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230817235428.never.111-kees@kernel.org> <20230817235859.49846-16-keescook@chromium.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230817235859.49846-16-keescook@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qWp0B-001BiV-3A X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:60186 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFdjoXwM408vQGwTbfbWTH4ppkxidj/uIXVt9P0r5kTMnKiyfFEhzxt7KcqMDjibO8f2l2ovJXVHDDR8K3s6YYk0lpDOYTZq0M/kVfOnNMvajYpvqfAG B9N2eoqCtZltJKvUynzZOtjF9FQQQGtW3tIZyONCN+uf3gWG+eMrdd5pjKNjw5Ml4G2ETObrdG3JP9xGzfCZOWreaB4HF1m4NLsHjMDhOjOojT8AVvd1+cec Ir95t/v5ZsnytMuhMo0MYt2cqWa7DFGw7uH4XkWTVoZ94wFzDfLb4xhoM5DlK1arh+rNnS1IVWc5Qs6W2XXbKCzgzNrR/iX8PBEfiB4gGkjk8qx4PqeQxBiQ Q2aM8gqJ9spXl1c8XizwSaxhejJPvty2Afp9riVCtu514RjAAnc= Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 8/17/23 17:58, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct tegra_adma. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Vinod Koul > Cc: Laxman Dewangan > Cc: Jon Hunter > Cc: Thierry Reding > Cc: dmaengine@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/dma/tegra210-adma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c > index e557bada1510..cea33912a4c9 100644 > --- a/drivers/dma/tegra210-adma.c > +++ b/drivers/dma/tegra210-adma.c > @@ -162,7 +162,7 @@ struct tegra_adma { > const struct tegra_adma_chip_data *cdata; > > /* Last member of the structure */ > - struct tegra_adma_chan channels[]; > + struct tegra_adma_chan channels[] __counted_by(nr_channels); > }; > > static inline void tdma_write(struct tegra_adma *tdma, u32 reg, u32 val)