From: Marc Dietrich <marvin24@gmx.de>
To: Franck Demathieu <fdemathieu@gmail.com>, linux-tegra@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] staging: nvec: Fix incorrect type of i2c address
Date: Tue, 14 Feb 2017 11:39:37 +0100 [thread overview]
Message-ID: <6772464.KSTSTH2iUx@fb07-iapwap2> (raw)
In-Reply-To: <20170213083519.10309-1-fdemathieu@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1079 bytes --]
Am Montag, 13. Februar 2017, 09:35:19 CET schrieb Franck Demathieu:
> From: Franck Demathieu <franck.demathieu@intel.com>
>
> The i2c address is unsigned according to the dt-bindings.
> Fix sparse issue (-Wtypesign):
>
> drivers/staging/nvec/nvec.c:781:35: warning: incorrect type in argument 3
> (different signedness) drivers/staging/nvec/nvec.c:781:35: expected
> unsigned int [usertype] *out_value drivers/staging/nvec/nvec.c:781:35:
> got int *<noident>
>
> Signed-off-by: Franck Demathieu <fdemathieu@gmail.com>
looks correct. Thanks!
Acked-by: Marc Dietrich <marvin24@gmx.de>
> ---
> drivers/staging/nvec/nvec.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/nvec/nvec.h b/drivers/staging/nvec/nvec.h
> index c03ca8d..aa7c70e 100644
> --- a/drivers/staging/nvec/nvec.h
> +++ b/drivers/staging/nvec/nvec.h
> @@ -138,7 +138,7 @@ struct nvec_chip {
> struct device *dev;
> int gpio;
> int irq;
> - int i2c_addr;
> + u32 i2c_addr;
> void __iomem *base;
> struct clk *i2c_clk;
> struct reset_control *rst;
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2017-02-14 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 8:35 [PATCH] staging: nvec: Fix incorrect type of i2c address Franck Demathieu
2017-02-14 10:39 ` Marc Dietrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6772464.KSTSTH2iUx@fb07-iapwap2 \
--to=marvin24@gmx.de \
--cc=devel@driverdev.osuosl.org \
--cc=fdemathieu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox