From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEA081B3; Thu, 23 Nov 2023 06:32:51 -0800 (PST) Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SbgV61xj0zsR57; Thu, 23 Nov 2023 22:29:18 +0800 (CST) Received: from [10.174.178.247] (10.174.178.247) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 23 Nov 2023 22:32:48 +0800 Subject: Re: [Patch v7] ACPI: processor: reduce CPUFREQ thermal reduction pctg for Tegra241 To: Sudeep Holla , Sumit Gupta CC: , , , , , , , , , , , , , , References: <20231123121433.12089-1-sumitg@nvidia.com> From: Hanjun Guo Message-ID: <6ccd1598-3c8b-1290-9494-01a3cdbb3003@huawei.com> Date: Thu, 23 Nov 2023 22:32:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected On 2023/11/23 22:00, Sudeep Holla wrote: > On Thu, Nov 23, 2023 at 05:44:33PM +0530, Sumit Gupta wrote: >> From: Srikar Srimath Tirumala >> >> Current implementation of processor_thermal performs software throttling >> in fixed steps of "20%" which can be too coarse for some platforms. >> We observed some performance gain after reducing the throttle percentage. >> Change the CPUFREQ thermal reduction percentage and maximum thermal steps >> to be configurable. Also, update the default values of both for Nvidia >> Tegra241 (Grace) SoC. The thermal reduction percentage is reduced to "5%" >> and accordingly the maximum number of thermal steps are increased as they >> are derived from the reduction percentage. >> >> Signed-off-by: Srikar Srimath Tirumala >> Co-developed-by: Sumit Gupta >> Signed-off-by: Sumit Gupta >> --- >> >> Sending this patch separately as the other patch in the series is >> applied by Rafael in v6[1]. Revision history before this version is >> in the cover letter of v6[1]. >> >> Please review and provide ACK if looks fine. >> > > For arm64 specific changes(a minor nit below though), > > Acked-by: Sudeep Holla > > > [...] > >> diff --git a/drivers/acpi/arm64/thermal_cpufreq.c b/drivers/acpi/arm64/thermal_cpufreq.c >> new file mode 100644 >> index 000000000000..d524f2cd6044 >> --- /dev/null >> +++ b/drivers/acpi/arm64/thermal_cpufreq.c >> @@ -0,0 +1,20 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +#include >> + >> +#include "../internal.h" >> + >> +#define SMCCC_SOC_ID_T241 0x036b0241 >> + > > [nit] We really need to find better place to define this globally and not > locally at each usage site like this. We already have it in GICv3 driver. > But that can come as a cleanup later if it causes issue for merging this > change. Agreed. Looks good to me as well. Acked-by: Hanjun Guo Thanks Hanjun