From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4BFC83F18 for ; Mon, 28 Aug 2023 15:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbjH1Pco convert rfc822-to-8bit (ORCPT ); Mon, 28 Aug 2023 11:32:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbjH1Pcl (ORCPT ); Mon, 28 Aug 2023 11:32:41 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE9B2A8; Mon, 28 Aug 2023 08:32:38 -0700 (PDT) Received: from hamburger.collabora.co.uk (hamburger.collabora.co.uk [IPv6:2a01:4f8:1c1c:f269::1]) by madras.collabora.co.uk (Postfix) with ESMTP id 332E2660716E; Mon, 28 Aug 2023 16:32:36 +0100 (BST) From: "Helen Mae Koike Fornazier" In-Reply-To: Content-Type: text/plain; charset="utf-8" X-Forward: 127.0.0.1 Date: Mon, 28 Aug 2023 16:32:35 +0100 Cc: ldewangan@nvidia.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sumit.semwal@linaro.org, linaro-mm-sig@lists.linaro.org, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, jonathanh@nvidia.com, christian.koenig@amd.com, linux-media@vger.kernel.org To: "Zhang Shurong" MIME-Version: 1.0 Message-ID: <6fd4-64ecbe00-3-213b7840@157890307> Subject: =?utf-8?q?Re=3A?= [PATCH] =?utf-8?q?spi=3A?==?utf-8?q?_tegra=3A?= Fix missing IRQ check in =?utf-8?q?tegra=5Fslink=5Fprobe()?= User-Agent: SOGoMail 5.8.4 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Saturday, August 26, 2023 07:02 -03, Zhang Shurong wrote: > This func misses checking for platform_get_irq()'s call and may passes the > negative error codes to request_irq(), which takes unsigned IRQ #, > causing it to fail with -EINVAL, overriding an original error code. > > Fix this by stop calling request_irq() with invalid IRQ #s. > > Fixes: dc4dc3605639 ("spi: tegra: add spi driver for SLINK controller") > Signed-off-by: Zhang Shurong Reviewed-by: Helen Koike > --- > drivers/spi/spi-tegra20-slink.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c > index 4d6db6182c5e..f5cd365c913a 100644 > --- a/drivers/spi/spi-tegra20-slink.c > +++ b/drivers/spi/spi-tegra20-slink.c > @@ -1086,6 +1086,8 @@ static int tegra_slink_probe(struct platform_device *pdev) > reset_control_deassert(tspi->rst); > > spi_irq = platform_get_irq(pdev, 0); > + if (spi_irq < 0) > + return spi_irq; > tspi->irq = spi_irq; > ret = request_threaded_irq(tspi->irq, tegra_slink_isr, > tegra_slink_isr_thread, IRQF_ONESHOT, > -- > 2.30.2 >