From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sumit Gupta Subject: Re: [TEGRA194_CPUFREQ PATCH v5 1/4] dt-bindings: arm: Add t194 ccplex compatible and bpmp property Date: Tue, 14 Jul 2020 17:13:47 +0530 Message-ID: <70a0a8ee-b79a-2a05-5150-2ee0faaf2730@nvidia.com> References: <1594649209-29394-1-git-send-email-sumitg@nvidia.com> <1594649209-29394-2-git-send-email-sumitg@nvidia.com> <20200713164214.GA341271@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200713164214.GA341271@bogus> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org, viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, talho-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bbasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, Sumit Gupta List-Id: linux-tegra@vger.kernel.org > On Mon, Jul 13, 2020 at 07:36:46PM +0530, Sumit Gupta wrote: >> To do frequency scaling on all CPUs within T194 CPU Complex, we need >> to query BPMP for data on valid operating points. Document a compatible >> string under 'cpus' node to represent the CPU Complex for binding drivers >> like cpufreq which don't have their node or CPU Complex node to bind to. >> Also, document a property to point to the BPMP device that can be queried >> for all CPUs. > > The cpus.yaml binding documents what's in 'cpu' nodes, not 'cpus' > node. AIUI, the latter is what you want. You should do your own schema > file here. > Do you mean to change existing file name from 'cpus.yaml' to 'cpu.yaml' and create new 'cpus.yaml' file? I think it's better to incorporate the change in existing 'cpus.yaml' file to keep both cpu@X and cpus node details together. Please suggest. >> >> Signed-off-by: Sumit Gupta >> --- >> Documentation/devicetree/bindings/arm/cpus.yaml | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml >> index a018147..9b328e3 100644 >> --- a/Documentation/devicetree/bindings/arm/cpus.yaml >> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml >> @@ -162,6 +162,7 @@ properties: >> - nvidia,tegra132-denver >> - nvidia,tegra186-denver >> - nvidia,tegra194-carmel >> + - nvidia,tegra194-ccplex > > Tegra194 has 2 different CPUs? > No, T194 SOC has homogeneous architecture with four clusters where each cluster has two symmetric cores. 'nvidia,tegra194-carmel' compatible string represents each cpu. 'nvidia,tegra194-ccplex' string represents the CPU Complex to bind cpufreq driver. The change was done as per discussion [1] >> - qcom,krait >> - qcom,kryo >> - qcom,kryo260 >> @@ -255,6 +256,15 @@ properties: >> >> where voltage is in V, frequency is in MHz. >> >> + nvidia,bpmp: >> + $ref: '/schemas/types.yaml#/definitions/phandle' >> + description: | >> + Specifies the bpmp node that needs to be queried to get >> + operating point data for all CPUs. >> + >> + Optional for systems that have a "compatible" >> + property value of "nvidia,tegra194-ccplex". >> + >> power-domains: >> $ref: '/schemas/types.yaml#/definitions/phandle-array' >> description: >> @@ -340,6 +350,7 @@ required: >> >> dependencies: >> rockchip,pmu: [enable-method] >> + nvidia,bpmp: [compatible] >> >> examples: >> - | >> -- >> 2.7.4 >> [1] https://marc.info/?l=linux-arm-kernel&m=158999171528418&w=2