From: Paolo Abeni <pabeni@redhat.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Paritosh Dixit <paritoshd@nvidia.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Bhadram Varka <vbhadram@nvidia.com>,
Revanth Kumar Uppala <ruppala@nvidia.com>,
netdev@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] net: stmmac: dwmac-tegra: Fix link bring-up sequence
Date: Tue, 1 Oct 2024 10:43:46 +0200 [thread overview]
Message-ID: <7485182b-797d-4476-b65c-7b1311d99442@redhat.com> (raw)
In-Reply-To: <6fdc8e96-0535-460f-a2da-cd698cff8324@nvidia.com>
On 9/27/24 17:28, Jon Hunter wrote:
> On 25/09/2024 14:40, Thierry Reding wrote:
>> All in all, I wonder if we wouldn't be better off increasing these
>> delays to the point where we can use usleep_range(). That will make
>> the overall lane bringup slightly longer (though it should still be well
>> below 1ms, so hardly noticeable from a user's perspective) but has the
>> benefit of not blocking the CPU during this time.
>
> Yes we can certainly increase the delay and use usleep_range() as you
> prefer. Let us know what you would recommend here.
Use of usleep_range() would be definitely preferrable.
Additionally, please replace c99 comments '// ...' with ansi ones:
'/* ... */'
Thanks,
Paolo
next prev parent reply other threads:[~2024-10-01 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 13:44 [PATCH] net: stmmac: dwmac-tegra: Fix link bring-up sequence Paritosh Dixit
2024-09-24 10:08 ` Jon Hunter
2024-09-25 13:40 ` Thierry Reding
2024-09-27 15:28 ` Jon Hunter
2024-10-01 8:43 ` Paolo Abeni [this message]
2024-10-07 13:50 ` Jon Hunter
2024-10-10 10:48 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7485182b-797d-4476-b65c-7b1311d99442@redhat.com \
--to=pabeni@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=jonathanh@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paritoshd@nvidia.com \
--cc=ruppala@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vbhadram@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).