Re: [PATCH v2 2/5] perf/arm_cspmu: Add callback to reset filter config

[Ilkka Koskinen <ilkka@os.amperecomputing.com>]

On Tue, 23 Sep 2025, Besar Wicaksono wrote:
> Implementer may need to reset a filter config when
> stopping a counter, thus adding a callback for this.
>
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>

Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>


> ---
> drivers/perf/arm_cspmu/arm_cspmu.c | 4 ++++
> drivers/perf/arm_cspmu/arm_cspmu.h | 4 +++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
> index 75b2d80f783e..43770c8ecd14 100644
> --- a/drivers/perf/arm_cspmu/arm_cspmu.c
> +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
> @@ -815,6 +815,10 @@ static void arm_cspmu_stop(struct perf_event *event, int pmu_flags)
> 		return;
>
> 	arm_cspmu_disable_counter(cspmu, hwc->idx);
> +
> +	if (cspmu->impl.ops.reset_ev_filter)
> +		cspmu->impl.ops.reset_ev_filter(cspmu, event);
> +
> 	arm_cspmu_event_update(event);
>
> 	hwc->state |= PERF_HES_STOPPED | PERF_HES_UPTODATE;
> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.h b/drivers/perf/arm_cspmu/arm_cspmu.h
> index 9c5f11f98acd..21d7e6e2f2da 100644
> --- a/drivers/perf/arm_cspmu/arm_cspmu.h
> +++ b/drivers/perf/arm_cspmu/arm_cspmu.h
> @@ -153,11 +153,13 @@ struct arm_cspmu_impl_ops {
> 	bool (*is_cycle_counter_event)(const struct perf_event *event);
> 	/* Decode event type/id from configs */
> 	u32 (*event_type)(const struct perf_event *event);
> -	/* Set event filters */
> +	/* Set/reset event filters */
> 	void (*set_cc_filter)(struct arm_cspmu *cspmu,
> 			      const struct perf_event *event);
> 	void (*set_ev_filter)(struct arm_cspmu *cspmu,
> 			      const struct perf_event *event);
> +	void (*reset_ev_filter)(struct arm_cspmu *cspmu,
> +				const struct perf_event *event);
> 	/* Implementation specific event validation */
> 	int (*validate_event)(struct arm_cspmu *cspmu,
> 			      struct perf_event *event);
> -- 
> 2.50.1
>
>