From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH] usb: chipidea: tegra: fix hardlock with invalid dr mode Date: Mon, 27 Jan 2020 18:38:00 +0300 Message-ID: <76f6d7b6-f4de-c2ae-ce6b-28847666c477@gmail.com> References: <20200127023548.27107-1-pgwipeout@gmail.com> <20200127071758.GD279449@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Geis , Greg KH Cc: Peter Chen , Thierry Reding , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 27.01.2020 18:25, Peter Geis пишет: > On Mon, Jan 27, 2020 at 2:18 AM Greg KH wrote: >> >> On Sun, Jan 26, 2020 at 09:35:48PM -0500, Peter Geis wrote: >>> The ci_hdrc_tegra driver does not currently support dual role mode, but >>> it does not explicitly prevent its use. >>> Certain devices support dual role mode, but not automatic role switch. >>> This can cause the device to lock up during initialization of the >>> driver. >>> >>> Detect this state by checking for the extcon phandle when dual role mode >>> is set to otg. >>> If it doesn't exist request the driver to only enable manual role >>> switching. >>> >>> Fixes: dfebb5f ("usb: chipidea: Add support for Tegra20/30/114/124") >> >> Please use 12 digits for kernel sha1 values, this should be: >> Fixes: dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124") > > Understood, thank you. > I will ensure that is the case in the future. Please also take a look at the kernel's scripts/checkpatch.pl, running 'scripts/checkpatch.pl --strict path_to.patch' will help to catch such things.