From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowjanya Komatineni Subject: Re: [PATCH V4 03/18] gpio: tegra: use resume_noirq for tegra gpio resume Date: Wed, 26 Jun 2019 10:06:33 -0700 Message-ID: <7b97ec08-212e-76fb-ad12-6d1be5ab6149@nvidia.com> References: <1561345379-2429-1-git-send-email-skomatineni@nvidia.com> <1561345379-2429-4-git-send-email-skomatineni@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Linus Walleij Cc: "thierry.reding@gmail.com" , Jon Hunter , Thomas Gleixner , Jason Cooper , Marc Zyngier , Stefan Agner , Mark Rutland , Peter De Schrijver , Prashant Gaikwad , Stephen Boyd , linux-clk , "open list:GPIO SUBSYSTEM" , jckuo@nvidia.com, Joseph Lo , talho@nvidia.com, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" , Mikko Perttunen , spatra@nvidia.com, Rob Herring , Dmitry List-Id: linux-tegra@vger.kernel.org On 6/25/19 6:38 AM, Linus Walleij wrote: > On Mon, Jun 24, 2019 at 5:03 AM Sowjanya Komatineni > wrote: > >> During SC7 resume, PARKED bit clear from the pinmux registers may >> cause a glitch on the GPIO lines. >> >> So, Tegra GPIOs restore should happen prior to restoring Tegra pinmux >> to keep the GPIO lines in a known good state prior to clearing PARKED >> bit. >> >> This patch has fix for this by moving Tegra GPIOs restore to happen >> very early than pinctrl resume. >> >> Signed-off-by: Sowjanya Komatineni > Can this patch be applied in isolation from the other patches? > > WOuld be nice to have at least Thierry's ACK on it before I > apply it. > > Yours, > Linus Walleij Just to confirm, Will not include this in V5 as you are planning to apply this patch separately. Thanks Sowjanya