From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH 9/9] memory: omap-gpmc: switch to platform_get_irq Date: Mon, 23 Dec 2019 09:25:20 +0200 Message-ID: <7dc78b4c-d1a7-a990-669c-8d3ddbacee0d@ti.com> References: <20191222185034.4665-1-tiny.windzz@gmail.com> <20191222185034.4665-9-tiny.windzz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191222185034.4665-9-tiny.windzz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Yangtao Li , ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, lukasz.luba-5wv7dgnIgG8@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, allison-wcfNWazeolPR7s880joybQ@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, jroedel-l3A5Bk7waGM@public.gmane.org, evgreen-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, rfontana-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org, alexios.zavras-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kstewart-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, info-EcKl7qYKIbxeoWH0uzbU5w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 22/12/2019 20:50, Yangtao Li wrote: > platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for > requesting IRQ's resources, as they can be not ready yet. Using > platform_get_irq() instead is preferred for getting IRQ even if it > was not retrieved earlier. > > Signed-off-by: Yangtao Li Acked-by: Roger Quadros > --- > drivers/memory/omap-gpmc.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index eff26c1b1394..6dd19d168f75 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -2366,13 +2366,9 @@ static int gpmc_probe(struct platform_device *pdev) > if (IS_ERR(gpmc_base)) > return PTR_ERR(gpmc_base); > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get resource: irq\n"); > - return -ENOENT; > - } > - > - gpmc->irq = res->start; > + gpmc->irq = platform_get_irq(pdev, 0); > + if (gpmc->irq < 0) > + return gpmc->irq; > > gpmc_l3_clk = devm_clk_get(&pdev->dev, "fck"); > if (IS_ERR(gpmc_l3_clk)) { > -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki