From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: John Crispin <john@phrozen.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
balbi@kernel.org, linux-usb@vger.kernel.org, digetx@gmail.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing
Date: Wed, 17 Mar 2021 09:16:11 +0100 [thread overview]
Message-ID: <804bb73f-7de0-e91b-ed57-a3b26de78fce@canonical.com> (raw)
In-Reply-To: <20210316215820.GA18064@alpha.franken.de>
On 16/03/2021 22:58, Thomas Bogendoerfer wrote:
> On Tue, Mar 16, 2021 at 06:57:25PM +0100, Krzysztof Kozlowski wrote:
>> The Ralink MIPS platform does not use Common Clock Framework and does
>> not define certain clock operations leading to compile test failures:
>>
>> /usr/bin/mips-linux-gnu-ld: drivers/usb/phy/phy-tegra-usb.o: in function `tegra_usb_phy_init':
>> phy-tegra-usb.c:(.text+0x1dd4): undefined reference to `clk_get_parent'
>
> hmm, why not make it use common clock framework ? And shouldn't
> include/linux/clk.h provide what you need, if CONFIG_HAVE_CLK is not set ?
Converting entire Ralink machine to the CCF is quite a task requiring
testing and basic knowledge about this platform. I am just trying to
plug the build failure reported some months ago [1][2]. The CCF does not
provide stubs if platform provides its own clocks.
[1] https://lore.kernel.org/lkml/202102170017.MgPVy7aZ-lkp@intel.com/
[2]
https://lore.kernel.org/lkml/20210316075551.10259-1-krzysztof.kozlowski@canonical.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-03-17 8:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 17:57 [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing Krzysztof Kozlowski
2021-03-16 18:01 ` John Crispin
2021-03-16 21:58 ` Thomas Bogendoerfer
2021-03-17 0:14 ` Dmitry Osipenko
2021-03-17 8:16 ` Krzysztof Kozlowski [this message]
2021-03-17 0:10 ` Dmitry Osipenko
2021-03-17 8:12 ` Krzysztof Kozlowski
2021-03-17 9:52 ` Sergei Shtylyov
2021-03-17 9:56 ` Krzysztof Kozlowski
2021-03-17 10:06 ` Sergei Shtylyov
2021-03-17 19:37 ` Dmitry Osipenko
2021-03-17 19:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804bb73f-7de0-e91b-ed57-a3b26de78fce@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=balbi@kernel.org \
--cc=digetx@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=thierry.reding@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox