Re: [PATCH 1/2] dt-bindings: gpio: Add Tegra410 support

[Kartik Rajput <kkartik@nvidia.com>]

On 29/09/25 19:11, Bartosz Golaszewski wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Mon, Sep 29, 2025 at 9:24 AM Kartik Rajput <kkartik@nvidia.com> wrote:
>>
>> Hi Conor,
>>
>> Thanks for reviewing the patch!
>>
>> On 19/09/25 22:44, Conor Dooley wrote:
>>> On Fri, Sep 19, 2025 at 03:06:26PM +0530, Kartik Rajput wrote:
>>>> From: Prathamesh Shete <pshete@nvidia.com>
>>>>
>>>> Add the port definitions for the main GPIO controller found on
>>>> Tegra410.
>>>>
>>>> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
>>>> Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
>>>> ---
>>>
>>> Why are you modifying a binding header for devicetree when the driver
>>> only appear to grow acpi support?
>>>
>>
>> Although Tegra410 is ACPI-only and does not require a new compatible string,
>> we chose to add the GPIO port definitions to the DT binding header to stay
>> consistent with previous Tegra SoCs.
>>
>> Thanks,
>> Kartik
>>
> 
> Hi!
> 
> The kernel policy is not to add symbols nobody is using. Please drop them.
> 
> Bartosz

Thanks Bartosz,

I have dropped the dt binding header in v2 and moved these macros to the
driver source instead as it is the only user.

Regards,
Kartik