From: Marc Zyngier <marc.zyngier@arm.com>
To: Aniruddha Banerjee <aniruddha.nitd@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
aniruddhab@nvidia.com, stable@vger.kernel.org, vipink@nvidia.com,
strasi@nvidia.com, swarren@nvidia.com, jonathanh@nvidia.com,
talho@nvidia.com, treding@nvidia.com
Subject: Re: [PATCHv4] irqchip: arm-gic: take gic_lock when updating irq type
Date: Wed, 28 Mar 2018 15:36:53 +0100 [thread overview]
Message-ID: <86370ks1ve.wl-marc.zyngier@arm.com> (raw)
In-Reply-To: <20180328134200.7435-1-aniruddha.nitd@gmail.com>
On Wed, 28 Mar 2018 14:42:00 +0100,
Aniruddha Banerjee wrote:
>
> From: Aniruddha Banerjee <aniruddhab@nvidia.com>
>
> The kernel documentation states that the locking of the irq-chip
> registers should be handled by the irq-chip driver. In the irq-gic,
> the accesses to the irqchip are seemingly not protected and multiple
> writes to SPIs from different irq descriptors do RMW requests without
> taking the irq-chip lock. When multiple irqs call the request_irq at
> the same time, there can be a simultaneous write at the gic
> distributor, leading to a race. Acquire the gic_lock when the
> irq_type is updated.
>
> Cc: stable@vger.kernel.org
>
> Signed-off-by: Aniruddha Banerjee <aniruddhab@nvidia.com>
I've applied this after having reworked the commit log a bit.
Thanks,
M.
--
Jazz is not dead, it just smell funny.
prev parent reply other threads:[~2018-03-28 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 13:42 [PATCHv4] irqchip: arm-gic: take gic_lock when updating irq type Aniruddha Banerjee
2018-03-28 14:36 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86370ks1ve.wl-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=aniruddha.nitd@gmail.com \
--cc=aniruddhab@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=strasi@nvidia.com \
--cc=swarren@nvidia.com \
--cc=talho@nvidia.com \
--cc=treding@nvidia.com \
--cc=vipink@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox