linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/tegra: Align BDL entry to 4KB boundary
@ 2022-09-05 17:24 Mohan Kumar
  2022-09-06  5:13 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Mohan Kumar @ 2022-09-05 17:24 UTC (permalink / raw)
  To: tiwai, perex, thierry.reding
  Cc: jonathanh, linux-tegra, alsa-devel, linux-kernel, Mohan Kumar

AZA HW may send a burst read/write request crossing 4K memory boundary.
The 4KB boundary is not guaranteed by Tegra HDA HW. Make SW change to
include the flag AZX_DCAPS_4K_BDLE_BOUNDARY to align BDLE to 4K
boundary.

Signed-off-by: Mohan Kumar <mkumard@nvidia.com>
---
 sound/pci/hda/hda_tegra.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
index 7debb2c76aa6..976a112c7d00 100644
--- a/sound/pci/hda/hda_tegra.c
+++ b/sound/pci/hda/hda_tegra.c
@@ -474,7 +474,8 @@ MODULE_DEVICE_TABLE(of, hda_tegra_match);
 static int hda_tegra_probe(struct platform_device *pdev)
 {
 	const unsigned int driver_flags = AZX_DCAPS_CORBRP_SELF_CLEAR |
-					  AZX_DCAPS_PM_RUNTIME;
+					  AZX_DCAPS_PM_RUNTIME |
+					  AZX_DCAPS_4K_BDLE_BOUNDARY;
 	struct snd_card *card;
 	struct azx *chip;
 	struct hda_tegra *hda;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: hda/tegra: Align BDL entry to 4KB boundary
  2022-09-05 17:24 [PATCH] ALSA: hda/tegra: Align BDL entry to 4KB boundary Mohan Kumar
@ 2022-09-06  5:13 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-09-06  5:13 UTC (permalink / raw)
  To: Mohan Kumar
  Cc: tiwai, perex, thierry.reding, jonathanh, linux-tegra, alsa-devel,
	linux-kernel

On Mon, 05 Sep 2022 19:24:20 +0200,
Mohan Kumar wrote:
> 
> AZA HW may send a burst read/write request crossing 4K memory boundary.
> The 4KB boundary is not guaranteed by Tegra HDA HW. Make SW change to
> include the flag AZX_DCAPS_4K_BDLE_BOUNDARY to align BDLE to 4K
> boundary.
> 
> Signed-off-by: Mohan Kumar <mkumard@nvidia.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-06  5:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-05 17:24 [PATCH] ALSA: hda/tegra: Align BDL entry to 4KB boundary Mohan Kumar
2022-09-06  5:13 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).