From: Jani Nikula <jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>,
Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH v2 1/2] drm: constify edid handling functions
Date: Wed, 16 Jan 2013 19:04:22 +0200 [thread overview]
Message-ID: <87fw21qctl.fsf@intel.com> (raw)
In-Reply-To: <1358352210.3157.8.camel@tellur>
On Wed, 16 Jan 2013, Lucas Stach <dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org> wrote:
> Am Mittwoch, den 16.01.2013, 16:23 +0100 schrieb Thierry Reding:
>> On Wed, Jan 16, 2013 at 03:36:41PM +0100, Lucas Stach wrote:
>> [...]
>> > @@ -705,7 +705,7 @@ static int standard_timing_level(struct edid *edid)
>> > * monitors fill with ascii space (0x20) instead.
>> > */
>> > static int
>> > -bad_std_timing(u8 a, u8 b)
>> > +bad_std_timing(const u8 a, const u8 b)
>> > {
>> > return (a == 0x00 && b == 0x00) ||
>> > (a == 0x01 && b == 0x01) ||
>>
>> Was this intended to go in here?
[...]
> Yes, probably I should have been a bit more elaborate in the commit
> message. Both hunks are intentional, as I looked at how those functions
> in the environment of the edid handling funcs are used and added const
> where appropriate, not just strictly to the struct edid pointer.
Please, let's not start constifying non-pointer parameters and local
variables.
BR,
Jani.
next prev parent reply other threads:[~2013-01-16 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 14:36 [PATCH v2 1/2] drm: constify edid handling functions Lucas Stach
[not found] ` <1358347002-10999-1-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-01-16 14:36 ` [PATCH v2 2/2] drm: tegra: check HDMI sink capability Lucas Stach
[not found] ` <1358347002-10999-2-git-send-email-dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>
2013-01-16 15:24 ` Thierry Reding
[not found] ` <20130116152421.GB965-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2013-01-16 16:05 ` Jon Mayo
2013-01-16 15:23 ` [PATCH v2 1/2] drm: constify edid handling functions Thierry Reding
2013-01-16 16:03 ` Lucas Stach
2013-01-16 17:04 ` Jani Nikula [this message]
[not found] ` <87fw21qctl.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-01-16 18:45 ` Thierry Reding
2013-01-16 16:44 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fw21qctl.fsf@intel.com \
--to=jani.nikula-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox