Re: [PATCH 06/10] drm/exynos: Set fbdev flags

Javier Martinez Canillas
2023-07-05T09:54:10Z

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Hi
>
> Am 05.07.23 um 10:49 schrieb Javier Martinez Canillas:

[...]

>>
>> The #define FBINFO_FLAG_DEFAULT FBINFO_DEFAULT seems to be there since the
>> original v2.6.12-rc2 git import in commit 1da177e4c3f4, so is hard to know
>> why was introduced. FBINFO_DEFAULT is more used, I will just stick to that:
>
> Thanks for commenting on this issue. I didn't notice that.
>
> I think I'll just remove these _DEFAULT assignments from the patchset.
>
> And I think we should nuke them entirely everywhere. The _DEFAULT values
> are just 0 after commit 376b3ff54c9a1. So there's no value in assigning
> them at all.
>

Agreed.

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat