From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: linux-tegra@vger.kernel.org, Mikko Perttunen <cyndis@kapsi.fi>,
dri-devel@lists.freedesktop.org,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] drm/tegra: Remove existing framebuffer only if we support display
Date: Thu, 07 Sep 2023 10:47:49 +0200 [thread overview]
Message-ID: <87tts62wui.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <dd898338-813f-df63-4255-986903aa7cb6@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
[...]
>> That's a good point. However I recall from earlier attempts at doing
>> something like this in Nouveau (although this is now very long ago) that
>> it's not very easy. The problem, as I recall, is that the driver is a
>> singleton, so we would essentially be supporting either modesetting or
>> not, for any device in the system.
>
> Take a look at struct drm_device.driver_features. It let's you clear the
> flags that your device doesn't support.
>
> https://elixir.bootlin.com/linux/v6.5/source/include/drm/drm_device.h#L128
>
That sounds indeed as the best approach and I see that at least i915 does it:
https://elixir.bootlin.com/linux/v6.5/source/drivers/gpu/drm/i915/intel_device_info.c#L418
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
prev parent reply other threads:[~2023-09-07 18:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 13:22 [PATCH] drm/tegra: Remove existing framebuffer only if we support display Thierry Reding
2023-08-30 6:13 ` Javier Martinez Canillas
2023-09-07 7:57 ` Thierry Reding
2023-09-07 8:11 ` Javier Martinez Canillas
2023-08-30 10:19 ` Thomas Zimmermann
2023-08-31 6:33 ` Mikko Perttunen
2023-08-31 8:04 ` Daniel Vetter
2023-09-07 8:03 ` Thierry Reding
2023-09-07 8:35 ` Thomas Zimmermann
2023-09-07 8:47 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tts62wui.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=cyndis@kapsi.fi \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox