[PATCH 0/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code

[PATCH 0/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code

[zhengbin]

zhengbin (2):
  drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in
    tegra_bo_dumb_create
  drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in tegra_gem_create

 drivers/gpu/drm/tegra/drm.c | 5 +----
 drivers/gpu/drm/tegra/gem.c | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in tegra_bo_dumb_create

[zhengbin]

Fixes coccicheck warning:

drivers/gpu/drm/tegra/gem.c:457:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/tegra/gem.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 746dae3..dae3efe 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -454,10 +454,7 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm,

 	bo = tegra_bo_create_with_handle(file, drm, args->size, 0,
 					 &args->handle);
-	if (IS_ERR(bo))
-		return PTR_ERR(bo);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(bo);
 }

 static vm_fault_t tegra_bo_fault(struct vm_fault *vmf)
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in tegra_gem_create

[zhengbin]

Fixes coccicheck warning:

drivers/gpu/drm/tegra/drm.c:350:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/gpu/drm/tegra/drm.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 56e5e7a..8b6a1f7d 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -347,10 +347,7 @@ static int tegra_gem_create(struct drm_device *drm, void *data,

 	bo = tegra_bo_create_with_handle(file, drm, args->size, args->flags,
 					 &args->handle);
-	if (IS_ERR(bo))
-		return PTR_ERR(bo);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(bo);
 }

 static int tegra_gem_mmap(struct drm_device *drm, void *data,
--
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 506 bytes --]

On Mon, Nov 18, 2019 at 07:46:10PM +0800, zhengbin wrote:
> zhengbin (2):
>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in
>     tegra_bo_dumb_create
>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in tegra_gem_create
> 
>  drivers/gpu/drm/tegra/drm.c | 5 +----
>  drivers/gpu/drm/tegra/gem.c | 5 +----
>  2 files changed, 2 insertions(+), 8 deletions(-)

As I explained in response to the same patches sent for other drivers
already, I don't think this has any merit.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code

[Jani Nikula]

On Mon, 18 Nov 2019, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Mon, Nov 18, 2019 at 07:46:10PM +0800, zhengbin wrote:
>> zhengbin (2):
>>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in
>>     tegra_bo_dumb_create
>>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in tegra_gem_create
>> 
>>  drivers/gpu/drm/tegra/drm.c | 5 +----
>>  drivers/gpu/drm/tegra/gem.c | 5 +----
>>  2 files changed, 2 insertions(+), 8 deletions(-)
>
> As I explained in response to the same patches sent for other drivers
> already, I don't think this has any merit.

I agree completely.

Apparently there's a coccicheck flagging constructs like this; perhaps
that should be addressed. Julia?

Things like:

drivers/gpu/drm/tegra/gem.c:457:1-3: WARNING: PTR_ERR_OR_ZERO can be used

leading to:

 -	if (IS_ERR(bo))
 -		return PTR_ERR(bo);
 -
 -	return 0;
 +	return PTR_ERR_OR_ZERO(bo);

I think we have consensus the error path and the happy day scenarios
should remain distinct. Moreover, I find PTR_ERR_OR_ZERO() causes me to
pause for a moment while the original is a crystal clear immediately.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code

[Jani Nikula]

On Tue, 19 Nov 2019, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 18 Nov 2019, Thierry Reding <thierry.reding@gmail.com> wrote:
>> On Mon, Nov 18, 2019 at 07:46:10PM +0800, zhengbin wrote:
>>> zhengbin (2):
>>>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in
>>>     tegra_bo_dumb_create
>>>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in tegra_gem_create
>>> 
>>>  drivers/gpu/drm/tegra/drm.c | 5 +----
>>>  drivers/gpu/drm/tegra/gem.c | 5 +----
>>>  2 files changed, 2 insertions(+), 8 deletions(-)
>>
>> As I explained in response to the same patches sent for other drivers
>> already, I don't think this has any merit.
>
> I agree completely.
>
> Apparently there's a coccicheck flagging constructs like this; perhaps
> that should be addressed. Julia?
>
> Things like:
>
> drivers/gpu/drm/tegra/gem.c:457:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> leading to:
>
>  -	if (IS_ERR(bo))
>  -		return PTR_ERR(bo);
>  -
>  -	return 0;
>  +	return PTR_ERR_OR_ZERO(bo);
>
> I think we have consensus the error path and the happy day scenarios
> should remain distinct. Moreover, I find PTR_ERR_OR_ZERO() causes me to
> pause for a moment while the original is a crystal clear immediately.

Re consensus, [1][2] and probably more. Per an email search, this pops
up for the same stuff over and over again. Can we please just remove the
cocci check?

BR,
Jani.


[1] http://mid.mail-archive.com/daade52d-0dfc-9365-b17c-02e7e785afad@ti.com
[2] http://mid.mail-archive.com/20191118130022.GM4345@gilmour.lan

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/2] drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code

[Julia Lawall]

On Tue, 19 Nov 2019, Jani Nikula wrote:

> On Tue, 19 Nov 2019, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Mon, 18 Nov 2019, Thierry Reding <thierry.reding@gmail.com> wrote:
> >> On Mon, Nov 18, 2019 at 07:46:10PM +0800, zhengbin wrote:
> >>> zhengbin (2):
> >>>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in
> >>>     tegra_bo_dumb_create
> >>>   drm/tegra: Use PTR_ERR_OR_ZERO() to simplify code in tegra_gem_create
> >>>
> >>>  drivers/gpu/drm/tegra/drm.c | 5 +----
> >>>  drivers/gpu/drm/tegra/gem.c | 5 +----
> >>>  2 files changed, 2 insertions(+), 8 deletions(-)
> >>
> >> As I explained in response to the same patches sent for other drivers
> >> already, I don't think this has any merit.
> >
> > I agree completely.
> >
> > Apparently there's a coccicheck flagging constructs like this; perhaps
> > that should be addressed. Julia?
> >
> > Things like:
> >
> > drivers/gpu/drm/tegra/gem.c:457:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> >
> > leading to:
> >
> >  -	if (IS_ERR(bo))
> >  -		return PTR_ERR(bo);
> >  -
> >  -	return 0;
> >  +	return PTR_ERR_OR_ZERO(bo);
> >
> > I think we have consensus the error path and the happy day scenarios
> > should remain distinct. Moreover, I find PTR_ERR_OR_ZERO() causes me to
> > pause for a moment while the original is a crystal clear immediately.
>
> Re consensus, [1][2] and probably more. Per an email search, this pops
> up for the same stuff over and over again. Can we please just remove the
> cocci check?

OK.

julia

>
> BR,
> Jani.
>
>
> [1] http://mid.mail-archive.com/daade52d-0dfc-9365-b17c-02e7e785afad@ti.com
> [2] http://mid.mail-archive.com/20191118130022.GM4345@gilmour.lan
>
> --
> Jani Nikula, Intel Open Source Graphics Center
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel