From: Felipe Balbi <balbi@kernel.org>
To: gregkh@linuxfoundation.org, thierry.reding@gmail.com,
jonathanh@nvidia.com
Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>
Subject: Re: [PATCH] usb: phy: tegra: Remove unnecessary spaces and tables
Date: Wed, 24 Jun 2020 09:45:20 +0300 [thread overview]
Message-ID: <87zh8tvu67.fsf@kernel.org> (raw)
In-Reply-To: <20200528112859.6160-1-tangbin@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
Hi,
Tang Bin <tangbin@cmss.chinamobile.com> writes:
> The macros in phy-tegra-usb.c have inconsistent sapces between
> the macro name and the value. Thus sets all the macros to have
> a signal space between the name and value.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/usb/phy/phy-tegra-usb.c | 214 ++++++++++++++++----------------
> 1 file changed, 107 insertions(+), 107 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> index 6153cc35a..c294dc617 100644
> --- a/drivers/usb/phy/phy-tegra-usb.c
> +++ b/drivers/usb/phy/phy-tegra-usb.c
> @@ -30,124 +30,124 @@
> #include <linux/usb/tegra_usb_phy.h>
> #include <linux/usb/ulpi.h>
>
> -#define ULPI_VIEWPORT 0x170
> +#define ULPI_VIEWPORT 0x170
>
> /* PORTSC PTS/PHCD bits, Tegra20 only */
> -#define TEGRA_USB_PORTSC1 0x184
> -#define TEGRA_USB_PORTSC1_PTS(x) (((x) & 0x3) << 30)
> -#define TEGRA_USB_PORTSC1_PHCD BIT(23)
> +#define TEGRA_USB_PORTSC1 0x184
> +#define TEGRA_USB_PORTSC1_PTS(x) (((x) & 0x3) << 30)
> +#define TEGRA_USB_PORTSC1_PHCD BIT(23)
the idea was the line up the definitions. I'm not taking this, sorry.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2020-06-24 6:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 11:28 [PATCH] usb: phy: tegra: Remove unnecessary spaces and tables Tang Bin
2020-06-24 6:45 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh8tvu67.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).