From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CC3DC71153 for ; Mon, 28 Aug 2023 16:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232677AbjH1QLl (ORCPT ); Mon, 28 Aug 2023 12:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232711AbjH1QLT (ORCPT ); Mon, 28 Aug 2023 12:11:19 -0400 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1491186; Mon, 28 Aug 2023 09:11:15 -0700 (PDT) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4RZFsp6GXsz9sV3; Mon, 28 Aug 2023 18:11:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1693239070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Aoaaryzi6SBqAG9hPq9YHz3/mtxEs0iaU4L1R/VYHlw=; b=MkBv4LmWqB4b8yilepEp0iTZf/XsZa8/Ct8sticPhsSKzvm4Ctczto5Rtrl5x79oopv8eg 29srTw4rlIoeV2p2oXlvwKAtZEHoIRGFv1iiPmAntjU3cR+V+2nNYzJ2sx2FUbYDcnooOl HfRGMoR6EMGx9Xaod1negh2/+FllGQiErZH6GtGuDDl+vPU48YW1V53VEOpesZlh5RQF0T WXRnCU/jlFI4tnv/XVOxIZAbzA+UeuNHD8q9yd6+NQq01hJauOcSg6aa778z7PMM5lEGvX dYJaG+1u73gNfrXHKZzfsVecd3N3G1b8gxC20QWYhY4TFpNSRINsebkVN6HNfw== Message-ID: <88d4d764-6b71-3eff-3e2c-31f2b2f3ea6f@mailbox.org> Date: Mon, 28 Aug 2023 18:11:05 +0200 MIME-Version: 1.0 Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Content-Language: de-CH-frami, en-CA To: Lee Jones , Jani Nikula Cc: Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Mikko Perttunen , =?UTF-8?Q?Ma=c3=adra_Canal?= , Thierry Reding , Laurent Pinchart , Sumit Semwal , Shashank Sharma , Michal Simek , amd-gfx@lists.freedesktop.org, Jonathan Hunter , Luben Tuikov , Danilo Krummrich , Ben Skeggs , Stanley Yang , linux-media@vger.kernel.org, Thomas Zimmermann , Sascha Hauer , Maxime Ripard , linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, Hyun Kwon , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Hawking Zhang , Jerome Glisse , Pengutronix Kernel Team , Alex Deucher , Gourav Samaiya , Shawn Guo , =?UTF-8?Q?Christian_K=c3=b6nig?= , Mario Limonciello References: <20230824073710.2677348-1-lee@kernel.org> <87wmxk4xt3.fsf@intel.com> <20230824120735.GS1380343@google.com> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= In-Reply-To: <20230824120735.GS1380343@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MBO-RS-META: ibs94ie8miru1dh146saewmp5c3pjzxf X-MBO-RS-ID: aab928bbbf67e7ef629 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 8/24/23 14:07, Lee Jones wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: >> On Thu, 24 Aug 2023, Lee Jones wrote: >>> This set is part of a larger effort attempting to clean-up W=1 >>> kernel builds, which are currently overwhelmingly riddled with >>> niggly little warnings. >> >> The next question is, how do we keep it W=1 clean going forward? > > My plan was to fix them all, then move each warning to W=0. > > Arnd recently submitted a set doing just that for a bunch of them. > > https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/ > > I like to think a bunch of this is built on top of my previous efforts. > > GPU is a particularly tricky though - the warnings seem to come in faster > than I can squash them. Maybe the maintainers can find a way to test > new patches on merge? One approach for this which has proved effective in Mesa and other projects is to make warnings fatal in CI which must pass for any changes to be merged. There is ongoing work toward introducing this for the DRM subsystem, using gitlab.freedesktop.org CI. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and Xwayland developer