From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bitan Biswas Subject: Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects Date: Wed, 5 Jun 2019 23:24:39 -0700 Message-ID: <89488516-a064-a1a0-9e3d-8234043201be@nvidia.com> References: <1559196850-7007-1-git-send-email-bbiswas@nvidia.com> <911e52ed-8f3c-583a-7610-e38723219eca@gmail.com> <2d83ad21-b012-1b3e-fc9a-741972ee3ba9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <2d83ad21-b012-1b3e-fc9a-741972ee3ba9@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko , Laxman Dewangan , Thierry Reding , Jonathan Hunter , linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Shardar Mohammed , Sowjanya Komatineni , Mantravadi Karthik List-Id: linux-tegra@vger.kernel.org On 5/31/19 5:45 AM, Dmitry Osipenko wrote: > 31.05.2019 12:04, Bitan Biswas =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> >> On 5/30/19 4:43 AM, Dmitry Osipenko wrote: >>> 30.05.2019 14:36, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> 30.05.2019 9:14, Bitan Biswas =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >>>>> except for BUG/BUG_ON checks >>>> >>>> Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire, >>>> hence there is absolutely no good reason in making system unusable on = a >>>> software bug. BUG_ON may be more useful for development, but not for a >>>> casual daily usage. >> I shall update the patch to remove the BUG/BUG_ON calls. >=20 > Please replace them with WARN_ON_ONCE. >=20 Based on review of the BUG_ON some were found redundant calls and hence=20 planned to be removed. Non-trivial BUG_ON planned to be replaced with=20 WARN_ON_ONCE call. -regards, Bitan