From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe() Date: Mon, 3 Jul 2017 12:35:18 +0100 Message-ID: <89de541e-355e-e79c-0090-cffefd277b4c@nvidia.com> References: <20170630072211.GA21867@embeddedgus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170630072211.GA21867@embeddedgus> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Gustavo A. R. Silva" , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 30/06/17 08:22, Gustavo A. R. Silva wrote: > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/devfreq/tegra-devfreq.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c > index 214fff9..ae71215 100644 > --- a/drivers/devfreq/tegra-devfreq.c > +++ b/drivers/devfreq/tegra-devfreq.c > @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "Failed to get IRQ\n"); > - return -ENODEV; > + if (irq < 0) { The changelog does not describe the above change and if/why this is ok. However, the original test looks fine to me and so I don't see a need to change this. > + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq); > + return irq; Why not have ... return irq ? irq : -ENODEV; Cheers Jon -- nvpublic