From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v3 04/10] ASoC: tegra: add Tegra210 based I2S driver Date: Thu, 20 Feb 2020 14:45:07 +0000 Message-ID: <8b224e0f-5e69-75a4-6be1-fb7bc083bf32@nvidia.com> References: <1582180492-25297-1-git-send-email-spujar@nvidia.com> <1582180492-25297-5-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1582180492-25297-5-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 20/02/2020 06:34, Sameer Pujar wrote: > The Inter-IC Sound (I2S) controller implements full-duplex, bi-directional > and single direction point to point serial interface. It can interface > with I2S compatible devices. Tegra I2S controller can operate as both > master and slave. > > This patch registers I2S controller with ASoC framework. The component > driver exposes DAPM widgets, routes and kcontrols for the device. The DAI > driver exposes I2S interfaces, which can be used to connect different > components in the ASoC layer. Makefile and Kconfig support is added to > allow to build the driver. The I2S devices can be enabled in the DT via > "nvidia,tegra210-i2s" compatible binding. > > Signed-off-by: Sameer Pujar > --- > sound/soc/tegra/Kconfig | 10 + > sound/soc/tegra/Makefile | 2 + > sound/soc/tegra/tegra210_i2s.c | 938 +++++++++++++++++++++++++++++++++++++++++ > sound/soc/tegra/tegra210_i2s.h | 132 ++++++ > 4 files changed, 1082 insertions(+) > create mode 100644 sound/soc/tegra/tegra210_i2s.c > create mode 100644 sound/soc/tegra/tegra210_i2s.h Thanks! Reviewed-by: Jon Hunter Cheers Jon -- nvpublic