From: Dmitry Osipenko <digetx@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>,
ldewangan@nvidia.com, jonathanh@nvidia.com,
dan.j.williams@intel.com, vkoul@kernel.org,
thierry.reding@gmail.com, swarren@wwwdotorg.org
Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused
Date: Fri, 20 Mar 2020 17:25:04 +0300 [thread overview]
Message-ID: <8d60faa5-2749-0581-7ee5-252f15b0e9cf@gmail.com> (raw)
In-Reply-To: <20200320071337.59756-1-yuehaibing@huawei.com>
20.03.2020 10:13, YueHaibing пишет:
> When CONFIG_PM is disabled, gcc warning this:
>
> drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function]
> drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function]
>
> Make it as __maybe_unused to fix the warnings,
> also remove unneeded function declarations.
>
> Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
...
Looks good, thank you:
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2020-03-20 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 7:13 [PATCH -next] dmaengine: tegra-apb: mark PM functions as __maybe_unused YueHaibing
2020-03-20 14:25 ` Dmitry Osipenko [this message]
[not found] ` <20200320071337.59756-1-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2020-03-20 15:11 ` Thierry Reding
2020-03-23 6:30 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d60faa5-2749-0581-7ee5-252f15b0e9cf@gmail.com \
--to=digetx@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).