From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v5 2/8] clk: tegra: Export functions for EMC clock scaling Date: Tue, 10 Mar 2020 19:13:25 +0300 Message-ID: <8e1f11e9-a95a-500f-ff44-6f44ad990863@gmail.com> References: <20200310152003.2945170-1-thierry.reding@gmail.com> <20200310152003.2945170-3-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200310152003.2945170-3-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Jon Hunter , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Joseph Lo , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org 10.03.2020 18:19, Thierry Reding пишет: > From: Joseph Lo > > Export functions to allow accessing the CAR register required by EMC > clock scaling. These functions will be used to access the CAR register > as part of the scaling sequence. > > Signed-off-by: Joseph Lo > Signed-off-by: Thierry Reding > --- > Changes in v5: > - remove tegra210_clk_emc_update_setting() which is no longer needed > ... > +EXPORT_SYMBOL_GPL(tegra210_clk_emc_update_setting); ... > +extern void tegra210_clk_emc_dll_enable(bool flag); > +extern void tegra210_clk_emc_dll_update_setting(u32 emc_dll_src_value); > +extern void tegra210_clk_emc_update_setting(u32 emc_src_value); Why these exports are needed given that the EMC driver is built-in?