From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manikanta Maddireddy Subject: Re: [PATCH V3 00/12] Enable Tegra root port features and apply SW fixups Date: Sun, 26 Nov 2017 01:29:26 +0530 Message-ID: <912eb378-2b12-0474-8c33-34113d23476b@nvidia.com> References: <1509371843-22931-1-git-send-email-mmaddireddy@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1509371843-22931-1-git-send-email-mmaddireddy-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kthota-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Bjorn, Thierry, Could you please review this series of patches? On 30-Oct-17 7:27 PM, Manikanta Maddireddy wrote: > These series of patches does the following things, > - Deasserting pcie_xrst after programming root port to make sure that > register programming is reflected during LTSSM > - Apply REFCLK pad settings to make sure P2P amplitude requirement is met > - Enable Gen2 link speed > - Advertise AER capability > - Program UPHY electrical settings for meeting eye diagram requirements > - Bunch of SW fixups explained in their respective commit log > > Testing done on Tegra124, 210 and 186: > - PCIe link up, config read, BAR read and basic functionality of Ethernet > card > - Link speed switch to Gen2 after link retrain > - Link speed stays in Gen1 after retrain if end point is only Gen1 capable > - Simulated AER errors and verified dmesg logs for them > - Rest of the programming is verified by dumping the registers after PCIe > link up > > Manikanta Maddireddy (12): > PCI: tegra: Start LTSSM after programming root port > PCI: tegra: Move REFCLK pad settings out of phy_power_on() > PCI: tegra: Retrain link for Gen2 speed > PCI: tegra: Advertise AER capability > PCI: tegra: Program UPHY electrical settings in Tegra210 > PCI: tegra: Enable opportunistic update FC and ACK > PCI: tegra: Disable AFI dynamic clock gating > PCI: tegra: Wait for DLLP to finish before entering L1 or L2 > PCI: tegra: Enable PCIe xclk clock clamping > PCI: tegra: Add SW fixup for RAW violations > PCI: tegra: Increase the deskew retry time > PCI: tegra: Update flow control threshold in Tegra210 > > drivers/pci/host/pci-tegra.c | 306 ++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 288 insertions(+), 18 deletions(-) >