From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 0/6] drivers/dma: drop modular code from non modular drivers Date: Thu, 10 Dec 2015 10:01:44 +0100 Message-ID: <9314789.uFZ258Jr2D@wuerfel> References: <1449703322-17762-1-git-send-email-paul.gortmaker@windriver.com> <7162994.ydt4N8UgZZ@wuerfel> <20151210001741.GT22885@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20151210001741.GT22885-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Paul Gortmaker , Alexandre Courbot , Stephen Warren , Vinod Koul , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Haojian Zhuang , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Laxman Dewangan , Thierry Reding , Daniel Mack , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dan Williams , Robert Jarzmik List-Id: linux-tegra@vger.kernel.org On Wednesday 09 December 2015 19:17:42 Paul Gortmaker wrote: > [Re: [PATCH 0/6] drivers/dma: drop modular code from non modular drivers] On 10/12/2015 (Thu 00:29) Arnd Bergmann wrote: > > > On Wednesday 09 December 2015 18:21:56 Paul Gortmaker wrote: > > > This series of commits is a slice of a larger project to ensure > > > people don't have dead code for module removal in non-modular > > > drivers. Overall there is roughly 5k lines of dead code in the > > > kernel due to this. > > > > > > There is a quasi-separate theme, in that some of the drivers were > > > allowing an unbind implicitly since it is enabled by default. But > > > for core DMA infrastructure drivers, this doesn't seem useful -- so > > > we also disable that here which allows us to delete any ".remove" > > > functions from the drivers that would otherwise be called during the > > > (impossible to trigger) module removal. > > > > > > Since ARM covers these files the best of all architectures, each > > > file was build tested for allmodconfig on ARM, which at the same > > > time confirms that the files are not built with "CC [M]" -- hence > > > genuinely non-modular. > > > > > > My testing and the larger patch series in general has been done > > > against the latest linux-next tree. > > > > > > > > > > We are in the process of changing the DMA drivers to a new way of > > passing the "filter" function around. We can soon build them > > all as loadable modules again. > > Hi Arnd, > > Thanks for the feedback -- just to clarify, you are suggesting I hold > on the series until I see what emerges in the next merge window? > > It may take a few cycles, but I think we'll get there and should not remove the unload logic from any of these drivers. When we're done, there is no reason for a dmaengine driver to be built-in. Arnd