From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v3 07/10] ASoC: tegra: add Tegra210 based ADMAIF driver Date: Thu, 20 Feb 2020 15:16:48 +0000 Message-ID: <995e806f-e5be-cb17-3660-93caa627e8e9@nvidia.com> References: <1582180492-25297-1-git-send-email-spujar@nvidia.com> <1582180492-25297-8-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1582180492-25297-8-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 20/02/2020 06:34, Sameer Pujar wrote: > ADMAIF is the interface between ADMA and AHUB. Each ADMA channel that > sends/receives data to/from AHUB must intreface through an ADMAIF channel. > ADMA channel sending data to AHUB pairs with an ADMAIF Tx channel and > similarly ADMA channel receiving data from AHUB pairs with an ADMAIF Rx > channel. Buffer size is configuranle for each ADMAIF channel, but currently > SW uses default values. > > This patch registers ADMAIF driver with ASoC framework. The component > driver exposes DAPM widgets, routes and kcontrols for the device. The DAI > driver exposes ADMAIF interfaces, which can be used to connect different > components in the ASoC layer. Makefile and Kconfig support is added to > allow to build the driver. The ADMAIF device can be enabled in the DT via > "nvidia,tegra210-admaif" compatible binding. > > Tegra PCM driver is updated to expose required PCM interfaces and > snd_pcm_ops callbacks. > > Signed-off-by: Sameer Pujar > --- > sound/soc/tegra/Kconfig | 12 + > sound/soc/tegra/Makefile | 2 + > sound/soc/tegra/tegra210_admaif.c | 884 ++++++++++++++++++++++++++++++++++++++ > sound/soc/tegra/tegra210_admaif.h | 164 +++++++ > sound/soc/tegra/tegra_pcm.c | 222 +++++++++- > sound/soc/tegra/tegra_pcm.h | 23 +- > 6 files changed, 1305 insertions(+), 2 deletions(-) > create mode 100644 sound/soc/tegra/tegra210_admaif.c > create mode 100644 sound/soc/tegra/tegra210_admaif.h Aside from Randy's comment ... Reviewed-by: Jon Hunter Cheers Jon -- nvpublic