Re: [PATCH 2/3] dt-bindings: sound: tegra: Update HDA resets

Thierry Reding
2021-12-07T08:18:28Z

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

On Tue, Dec 07, 2021 at 12:02:49PM +0530, Sameer Pujar wrote:
> Tegra194 HDA has only two resets unlike the previous generations of
> Tegra SoCs. Hence update the reset list accordingly.
>
> Fixes: 2d8f8955fe02 ("dt-bindings: tegra: Convert HDA doc to json-schema")
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
> .../devicetree/bindings/sound/nvidia,tegra30-hda.yaml | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> index b55775e..70dbdff5 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-hda.yaml
> @@ -50,13 +50,18 @@ properties:
> - const: hda2codec_2x
>
> resets:
> + minItems: 2
> maxItems: 3
>
> reset-names:
> - items:
> - - const: hda
> - - const: hda2hdmi
> - - const: hda2codec_2x
> + oneOf:
> + - items:
> + - const: hda
> + - const: hda2hdmi
> + - const: hda2codec_2x
> + - items:
> + - const: hda
> + - const: hda2hdmi

We could make this more specific using an if: conditional and match on
nvidia,tegra194-hda, but this would work as well, especially since I
presume that Tegra194's successors will also not have the hda2codec_2x
reset.

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]