From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH 09/73] ARM: tegra: gr2d is not backwards-compatible Date: Wed, 17 Jun 2020 19:21:30 +0300 Message-ID: <9f56be9a-1a79-07cc-371f-f3abcd20701e@gmail.com> References: <20200616135238.3001888-1-thierry.reding@gmail.com> <20200616135238.3001888-10-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200616135238.3001888-10-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jon Hunter List-Id: linux-tegra@vger.kernel.org 16.06.2020 16:51, Thierry Reding пишет: > From: Thierry Reding > > The instantiation of gr2d in Tegra114 is not backwards-compatible with > the version found on earlier chips. Remove the misleading compatible > string. > > Signed-off-by: Thierry Reding > --- > arch/arm/boot/dts/tegra114.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi > index a0ac9ea9ec9d..d583dfba688f 100644 > --- a/arch/arm/boot/dts/tegra114.dtsi > +++ b/arch/arm/boot/dts/tegra114.dtsi > @@ -35,7 +35,7 @@ host1x@50000000 { > ranges = <0x54000000 0x54000000 0x01000000>; > > gr2d@54140000 { > - compatible = "nvidia,tegra114-gr2d", "nvidia,tegra20-gr2d"; > + compatible = "nvidia,tegra114-gr2d"; > reg = <0x54140000 0x00040000>; > interrupts = ; > clocks = <&tegra_car TEGRA114_CLK_GR2D>; > Could you please explain what's the difference? AFAIK, the 2D HW is identical on T20/30/114.