From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: tegra: bpmp: fix T234 build failure
Date: Fri, 4 Dec 2020 12:11:20 +0100 [thread overview]
Message-ID: <X8oZWMhARPcieFW7@ulmo> (raw)
In-Reply-To: <20201203230625.1480626-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On Fri, Dec 04, 2020 at 12:06:20AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When only Tegra 234 is enabled, the bpmp driver fails
> to build:
>
> drivers/firmware/tegra/bpmp.c:861:51: error: 'tegra186_soc' undeclared here (not in a function)
> 861 | { .compatible = "nvidia,tegra186-bpmp", .data = &tegra186_soc },
> | ^~~~~~~~~~~~
>
> Fix the #ifdef statement to match the location in which this
> symbol is used.
>
> Fixes: 0ebdf11699d0 ("firmware: tegra: Enable BPMP support on Tegra234")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/firmware/tegra/Makefile | 1 +
> drivers/firmware/tegra/bpmp-private.h | 3 ++-
> drivers/firmware/tegra/bpmp.c | 3 ++-
> 3 files changed, 5 insertions(+), 2 deletions(-)
Sigh... I wonder if I should just give up and eliminate all
ARCH_TEGRA_XYZ_SOC options. There's not a lot that we gain by keeping
them around and most people will be building multi-platform
configurations anyway, so there's very little point to it.
Anyway, this looks good, so:
Acked-by: Thierry Reding <treding@nvidia.com>
Let me know if you'd prefer me to pick this up and send as a follow-up
pull request for Tegra.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-12-04 11:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 23:06 [PATCH] firmware: tegra: bpmp: fix T234 build failure Arnd Bergmann
2020-12-04 11:11 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8oZWMhARPcieFW7@ulmo \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).