From: Mark Brown <broonie@kernel.org>
To: Krishna Yarlagadda <kyarlagadda@nvidia.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [Patch V3 1/3] tpm_tis-spi: Support hardware wait polling
Date: Fri, 24 Feb 2023 15:51:41 +0000 [thread overview]
Message-ID: <Y/jdDeBPM//W5WG8@sirena.org.uk> (raw)
In-Reply-To: <DM4PR12MB5769C60EFD807376CE09DC3FC3A89@DM4PR12MB5769.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Fri, Feb 24, 2023 at 02:16:27PM +0000, Krishna Yarlagadda wrote:
> > > > > + spi_bus_lock(phy->spi_device->master);
> > > > > +
> > > > > + while (len) {
> > > > Why?
> > > TPM supports max 64B in single transaction. Loop to send rest of it.
> > No, why is there a bus lock?
> Bus lock to avoid other clients to be accessed between TPM transfers.
That's what a bus lock does but what would be the problem if something
else sent a message between messages? Note that a message will always
be sent atomically.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-24 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 16:26 [Patch V3 0/3] Tegra TPM driver with HW flow control Krishna Yarlagadda
2023-02-23 16:26 ` [Patch V3 1/3] tpm_tis-spi: Support hardware wait polling Krishna Yarlagadda
2023-02-23 17:18 ` Mark Brown
2023-02-23 18:41 ` Krishna Yarlagadda
2023-02-23 18:43 ` Mark Brown
2023-02-24 14:16 ` Krishna Yarlagadda
2023-02-24 15:51 ` Mark Brown [this message]
2023-02-24 16:21 ` Krishna Yarlagadda
2023-02-23 16:26 ` [Patch V3 2/3] spi: tegra210-quad: set half duplex flag Krishna Yarlagadda
2023-02-23 16:26 ` [Patch V3 3/3] spi: tegra210-quad: Enable TPM wait polling Krishna Yarlagadda
2023-02-23 17:28 ` Mark Brown
2023-02-23 18:46 ` Krishna Yarlagadda
2023-02-23 18:31 ` (subset) [Patch V3 0/3] Tegra TPM driver with HW flow control Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/jdDeBPM//W5WG8@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=robh+dt@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox