From: Thierry Reding <thierry.reding@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Mark Brown <broonie@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-tegra@vger.kernel.org, linux-spi@vger.kernel.org,
Krishna Yarlagadda <kyarlagadda@nvidia.com>
Subject: Re: [PATCH] spi: tegra210-quad: Don't initialise DMA if not supported
Date: Fri, 28 Oct 2022 13:22:20 +0200 [thread overview]
Message-ID: <Y1u7bDYd78vb5FyT@orome> (raw)
In-Reply-To: <20221026155633.141792-1-jonathanh@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Wed, Oct 26, 2022 at 04:56:33PM +0100, Jon Hunter wrote:
> The following error messages are observed on boot for Tegra234 ...
>
> ERR KERN tegra-qspi 3270000.spi: cannot use DMA: -19
> ERR KERN tegra-qspi 3270000.spi: falling back to PIO
>
> Tegra234 does not support DMA for the QSPI and so initialising the DMA
> is expected to fail. The above error messages are misleading for devices
> that don't support DMA and so fix this by skipping the DMA
> initialisation for devices that don't support DMA.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/spi/spi-tegra210-quad.c | 6 ++++++
> 1 file changed, 6 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-28 11:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 15:56 [PATCH] spi: tegra210-quad: Don't initialise DMA if not supported Jon Hunter
2022-10-28 11:22 ` Thierry Reding [this message]
2022-10-28 18:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1u7bDYd78vb5FyT@orome \
--to=thierry.reding@gmail.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kyarlagadda@nvidia.com \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox