Re: [PATCH v3 01/13] dt-bindings: usb: tegra-xudc: Add Tegra234 XUSB controller support

Jon Hunter
2022-11-17T12:05:56Z

On 16/11/2022 21:05, Rob Herring wrote:
> On Mon, Nov 14, 2022 at 08:40:41PM +0800, Wayne Chang wrote:
>> Extend the Tegra XUSB controller device tree binding with Tegra234
>> support.
>
> Why do you need any order and number of phys? Please explain in the
> commit msg.

I have been having a quick look at this and for the devices that
this binding is applicable to, they only support one port for USB2
and one port for USB3. So I don't think that we should have all
these ports defined in this binding doc. So ideally, we should have
...

diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
index 52488a731c4e..031796b68bbb 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra-xudc.yaml
@@ -98,17 +98,9 @@ properties:

phy-names:
minItems: 1
- maxItems: 8
items:
- enum:
- - usb2-0
- - usb2-1
- - usb2-2
- - usb2-3
- - usb3-0
- - usb3-1
- - usb3-2
- - usb3-3
+ - const: usb2
+ - const: usb3

dma-coherent:
type: boolean
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
index 0556bc64287d..349a98119608 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
@@ -2128,7 +2128,7 @@ usb@3550000 {

phys = <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-0}>,
<&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-1}>;
- phy-names = "usb2-0", "usb3-1";
+ phy-names = "usb2", "usb3";
};

usb@3610000 {

Jon

--
nvpublic