From: Thierry Reding <thierry.reding@gmail.com>
To: Ashish Mhetre <amhetre@nvidia.com>
Cc: krzysztof.kozlowski@linaro.org, jonathanh@nvidia.com,
dmitry.osipenko@collabora.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [Patch V3] memory: tegra: Remove clients SID override programming
Date: Fri, 25 Nov 2022 16:57:56 +0100 [thread overview]
Message-ID: <Y4DmBBthyfnv4noI@orome> (raw)
In-Reply-To: <20221125040752.12627-1-amhetre@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
On Fri, Nov 25, 2022 at 09:37:52AM +0530, Ashish Mhetre wrote:
> On newer Tegra releases, early boot SID override programming and SID
> override programming during resume is handled by bootloader.
> In the function tegra186_mc_program_sid() which is getting removed, SID
> override register of all clients is written without checking if secure
> firmware has allowed write on it or not. If write is disabled by secure
> firmware then it can lead to errors coming from secure firmware and hang
> in kernel boot.
> Also, SID override is programmed on-demand during probe_finalize() call
> of IOMMU which is done in tegra186_mc_client_sid_override() in this same
> file. This function does it correctly by checking if write is permitted
> on SID override register. It also checks if SID override register is
> already written with correct value and skips re-writing it in that case.
>
> Fixes: 393d66fd2cac ("memory: tegra: Implement SID override programming")
> Signed-off-by: Ashish Mhetre <amhetre@nvidia.com>
> ---
> Changes in v3:
> - Updated the commit message to point out the bug fix.
>
> Changes in v2:
> - After offline discussions with Thierry and Jonathan, removed SID
> override programming during resume as well.
>
>
> drivers/memory/tegra/tegra186.c | 36 ---------------------------------
> 1 file changed, 36 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-25 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 4:07 [Patch V3] memory: tegra: Remove clients SID override programming Ashish Mhetre
2022-11-25 15:57 ` Thierry Reding [this message]
2022-12-27 8:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4DmBBthyfnv4noI@orome \
--to=thierry.reding@gmail.com \
--cc=amhetre@nvidia.com \
--cc=dmitry.osipenko@collabora.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).