Re: [PATCH V4 1/5] dt-bindings: usb: Add binding for Cypress cypd4226 I2C driver

Jon Hunter
2023-01-17T17:22:45Z

On 16/01/2023 19:03, Krzysztof Kozlowski wrote:
> On 16/01/2023 16:50, Jon Hunter wrote:
>> From: Wayne Chang <waynec@nvidia.com>
>>
>> add device-tree binding documentation for Cypress cypd4226 type-C
>> controller's I2C interface. It is a standard i2c slave with GPIO
>> input as IRQ interface.
>>
>> Signed-off-by: Wayne Chang <waynec@nvidia.com>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> V3 -> V4: no changes
>> V2 -> V3: fix additionalProperties warning on new schema
>> V1 -> V2: based on the review comments. Fix some addressed issues on
>>
>> .../bindings/usb/cypress,cypd4226.yaml | 86 +++++++++++++++++++
>> 1 file changed, 86 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>> new file mode 100644
>> index 000000000000..5ac28ab4e7a1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
>> @@ -0,0 +1,86 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/usb/cypress,cypd4226.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Cypress cypd4226 UCSI I2C Type-C Controller
>> +
>> +maintainers:
>> + - Wayne Chang <waynec@nvidia.com>
>> +
>> +description: |
>> + The Cypress cypd4226 UCSI I2C type-C controller is a I2C interface type-C
>> + controller.
>> +
>> +properties:
>> + compatible:
>> + const: cypress,cypd4226
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>> +
>> + reg:
>> + const: 0x08
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + cypress,firmware-build:
>> + enum:
>> + - nv
>> + - gn
>> + description: |
>> + the name of the CCGx firmware built for product series.
>> + should be set one of following:
>> + - "nv" for the RTX product series
>> + - "gn" for the Jetson product series
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.

Thanks. Apologies for this. I will sort this out in the next revision.

Jon

--
nvpublic