RE: [PATCH V10 4/6] i2c: nvidia-gpu: Remove ccgx,firmware-build property

Ajay Gupta
2023-02-01T20:34:05Z

Hi,
> -----Original Message-----
> From: Jonathan Hunter <jonathanh@nvidia.com>
> Sent: Wednesday, February 1, 2023 12:23 PM
> To: Heikki Krogerus <heikki.krogerus@linux.intel.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Thierry Reding
> <thierry.reding@gmail.com>; Wolfram Sang <wsa+renesas@sang-
> engineering.com>; Ajay Gupta <ajayg@nvidia.com>
> Cc: linux-usb@vger.kernel.org; devicetree@vger.kernel.org; linux-
> tegra@vger.kernel.org; Wayne Chang <waynec@nvidia.com>
> Subject: Re: [PATCH V10 4/6] i2c: nvidia-gpu: Remove ccgx,firmware-build
> property
>
> Adding Ajay as well.
>
> On 01/02/2023 16:01, Jon Hunter wrote:
> > Adding Wolfram.
> >
> > On 31/01/2023 17:57, Jon Hunter wrote:
> >> From: Wayne Chang <waynec@nvidia.com>
> >>
> >> Now the Cypress CCG driver has been updated to support the
> >> 'firmware-name' property to align with device-tree, remove the
> >> 'ccgx,firmware-build' property as this is no longer needed.

Acked-by: Ajay Gupta <ajayg@nvidia.com>

Thanks
> >> nvpublic
> >>
> >> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> >> ---
> >> V6 -> V10: no changes
> >> V5: Added this patch from V3
> >>
> >>   drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
> >>   1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c
> >> b/drivers/i2c/busses/i2c-nvidia-gpu.c
> >> index 6d81ea530a83..a8b99e7f6262 100644
> >> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> >> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> >> @@ -259,8 +259,7 @@ static const struct pci_device_id gpu_i2c_ids[] =
> >> {
> >>   MODULE_DEVICE_TABLE(pci, gpu_i2c_ids);
> >>   static const struct property_entry ccgx_props[] = {
> >> -    /* Use FW built for NVIDIA (nv) only */
> >> -    PROPERTY_ENTRY_U16("ccgx,firmware-build", ('n' << 8) | 'v'),
> >> +    /* Use FW built for NVIDIA GPU only */
> >>       PROPERTY_ENTRY_STRING("firmware-name", "nvidia,gpu"),
> >>       { }
> >>   };
> >
>
> --
> nvpublic