From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Matt Merhar <mattmerhar@protonmail.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1] ARM: tegra: Don't enable unused PLLs on resume from suspend
Date: Tue, 19 Jan 2021 18:24:53 +0100 [thread overview]
Message-ID: <YAcV5WX+VPfq5y1y@ulmo> (raw)
In-Reply-To: <20210112135031.3196-1-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On Tue, Jan 12, 2021 at 04:50:31PM +0300, Dmitry Osipenko wrote:
> PLLC and PLLM are usually disabled on system suspend because all devices
> which use these PLLs are either suspended or switched away to other clock
> source. Don't enable unused PLLs on resume from suspend by keeping track
> of the enable-state of the PLLs across suspend-resume.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> arch/arm/mach-tegra/sleep-tegra20.S | 38 ++++++++++--
> arch/arm/mach-tegra/sleep-tegra30.S | 94 +++++++++++++++++++++++------
> 2 files changed, 108 insertions(+), 24 deletions(-)
For future patches with this many tested-bys, can you collect a bit of
information about where these were tested? That'd be a good way to get a
better understanding of the coverage and a good way to collect a bit of
information about what devices are being used.
I've seen a pattern like this used sometimes:
Tested-by: Name <email> # Board that was tested on
So perhaps we can adopt this for these cases?
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-19 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 13:50 [PATCH v1] ARM: tegra: Don't enable unused PLLs on resume from suspend Dmitry Osipenko
2021-01-19 17:24 ` Thierry Reding [this message]
2021-01-19 17:31 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAcV5WX+VPfq5y1y@ulmo \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox