From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Mikko Perttunen <cyndis@kapsi.fi>,
Mikko Perttunen <mperttunen@nvidia.com>,
jonathanh@nvidia.com, airlied@linux.ie, daniel@ffwll.ch,
linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
talho@nvidia.com, bhuntsman@nvidia.com
Subject: Re: [PATCH v5 19/21] drm/tegra: Implement new UAPI
Date: Tue, 23 Mar 2021 17:59:16 +0100 [thread overview]
Message-ID: <YFoeZGptRcu6sism@orome.fritz.box> (raw)
In-Reply-To: <2c557b45-f78c-5f49-7f9f-e84edacd4a08@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Tue, Mar 23, 2021 at 06:00:34PM +0300, Dmitry Osipenko wrote:
> 23.03.2021 17:43, Mikko Perttunen пишет:
> >>
> >> FWIW, I would've been fine with stashing all of this into drm.c as well
> >> since the rest of the UAPI is in that already. The churn in this patch
> >> is reasonably small, but it would've been even less if this was just all
> >> in drm.c.
> >
> > I think we shouldn't have the uapi in drm.c -- it just makes the file a
> > bit of a dumping ground. I think drm.c should have the code that relates
> > to initialization and initial registration with DRM.
>
> +1 drm.c is already very unmanageable / difficult to follow, it
> absolutely must be split up.
I guess this comes down to personal preference. I don't find it
difficult to navigate large files. On the contrary, I find it much more
challenging to navigate a code base spread over lots and lots of files.
I don't feel strongly about moving this code into a separate file,
though, but let's maybe compromise and leave it at that. No need to
split this out into 5 (or whatever it was) different tiny files that
the end result of this series seems to yield.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-23 16:59 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 12:59 [PATCH v5 00/21] Host1x/TegraDRM UAPI Mikko Perttunen
2021-01-11 12:59 ` [PATCH v5 01/21] gpu: host1x: Use different lock classes for each client Mikko Perttunen
2021-03-22 14:46 ` Thierry Reding
2021-03-22 14:48 ` Dmitry Osipenko
2021-03-22 15:19 ` Mikko Perttunen
2021-03-22 16:01 ` Dmitry Osipenko
2021-03-23 10:20 ` Thierry Reding
2021-03-23 13:25 ` Dmitry Osipenko
2021-03-26 14:54 ` Mikko Perttunen
2021-03-26 18:31 ` Dmitry Osipenko
2021-03-26 19:10 ` Mikko Perttunen
2021-03-26 22:47 ` Dmitry Osipenko
2021-01-11 13:00 ` [PATCH v5 02/21] gpu: host1x: Allow syncpoints without associated client Mikko Perttunen
2021-03-23 10:10 ` Thierry Reding
2021-03-23 10:32 ` Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs Mikko Perttunen
2021-03-23 10:16 ` Thierry Reding
2021-03-26 14:34 ` Mikko Perttunen
2021-04-01 21:19 ` Michał Mirosław
2021-04-02 16:02 ` Dmitry Osipenko
2021-04-08 4:13 ` Michał Mirosław
2021-04-08 4:25 ` Michał Mirosław
2021-04-08 11:58 ` Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 04/21] gpu: host1x: Remove cancelled waiters immediately Mikko Perttunen
2021-01-12 22:07 ` Dmitry Osipenko
2021-01-12 22:20 ` Mikko Perttunen
2021-01-13 16:29 ` Dmitry Osipenko
2021-01-13 18:16 ` Mikko Perttunen
2021-03-23 10:23 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 05/21] gpu: host1x: Use HW-equivalent syncpoint expiration check Mikko Perttunen
2021-03-23 10:26 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 06/21] gpu: host1x: Cleanup and refcounting for syncpoints Mikko Perttunen
2021-03-23 10:36 ` Thierry Reding
2021-03-23 10:44 ` Mikko Perttunen
2021-03-23 11:21 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 07/21] gpu: host1x: Introduce UAPI header Mikko Perttunen
2021-03-23 10:52 ` Thierry Reding
2021-03-23 11:12 ` Mikko Perttunen
2021-03-23 11:43 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 08/21] gpu: host1x: Implement /dev/host1x device node Mikko Perttunen
2021-03-23 11:02 ` Thierry Reding
2021-03-23 11:15 ` Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 09/21] gpu: host1x: DMA fences and userspace fence creation Mikko Perttunen
2021-03-23 11:15 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 10/21] gpu: host1x: Add no-recovery mode Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 11/21] gpu: host1x: Add job release callback Mikko Perttunen
2021-03-23 11:55 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 12/21] gpu: host1x: Add support for syncpoint waits in CDMA pushbuffer Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 13/21] gpu: host1x: Reset max value when freeing a syncpoint Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 14/21] gpu: host1x: Reserve VBLANK syncpoints at initialization Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 15/21] drm/tegra: Add new UAPI to header Mikko Perttunen
2021-01-13 18:14 ` Dmitry Osipenko
2021-01-13 18:56 ` Mikko Perttunen
2021-01-14 8:36 ` Dmitry Osipenko
2021-01-14 10:34 ` Mikko Perttunen
2021-03-23 12:30 ` Thierry Reding
2021-03-23 14:00 ` Dmitry Osipenko
2021-03-23 16:44 ` Thierry Reding
2021-03-23 17:32 ` Dmitry Osipenko
2021-03-23 17:57 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 16/21] drm/tegra: Boot VIC during runtime PM resume Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 17/21] drm/tegra: Set resv fields when importing/exporting GEMs Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 18/21] drm/tegra: Allocate per-engine channel in core code Mikko Perttunen
2021-03-23 12:35 ` Thierry Reding
2021-03-23 13:15 ` Mikko Perttunen
2021-01-11 13:00 ` [PATCH v5 19/21] drm/tegra: Implement new UAPI Mikko Perttunen
2021-01-11 17:37 ` kernel test robot
2021-01-12 22:27 ` Dmitry Osipenko
2021-03-23 13:25 ` Thierry Reding
2021-03-23 14:43 ` Mikko Perttunen
2021-03-23 15:00 ` Dmitry Osipenko
2021-03-23 16:59 ` Thierry Reding [this message]
2021-01-11 13:00 ` [PATCH v5 20/21] drm/tegra: Implement job submission part of " Mikko Perttunen
2021-03-23 13:38 ` Thierry Reding
2021-03-23 14:16 ` Mikko Perttunen
2021-03-23 17:04 ` Thierry Reding
2021-01-11 13:00 ` [PATCH v5 21/21] drm/tegra: Add job firewall Mikko Perttunen
2021-01-19 22:29 ` [PATCH v5 00/21] Host1x/TegraDRM UAPI Dmitry Osipenko
2021-01-26 2:45 ` Mikko Perttunen
2021-01-27 21:20 ` [PATCH v5 00/21] Host1x sync point UAPI should not be used for tracking DRM jobs Dmitry Osipenko
2021-01-28 11:08 ` Mikko Perttunen
2021-01-28 16:58 ` Thierry Reding
2021-01-29 17:30 ` Dmitry Osipenko
2021-02-03 11:18 ` Mikko Perttunen
2021-02-27 11:19 ` Dmitry Osipenko
2021-03-01 8:19 ` Mikko Perttunen
2021-03-23 18:21 ` Thierry Reding
2021-03-23 19:57 ` Dmitry Osipenko
2021-03-23 20:13 ` Dmitry Osipenko
2021-01-27 21:26 ` [PATCH v5 00/21] Host1x/TegraDRM UAPI Dmitry Osipenko
2021-01-27 21:57 ` Mikko Perttunen
2021-01-27 22:06 ` Dmitry Osipenko
2021-01-28 11:46 ` Mikko Perttunen
2021-01-27 21:35 ` [PATCH v5 00/21] sync_file API is not very suitable for DRM Dmitry Osipenko
2021-01-27 21:53 ` Mikko Perttunen
2021-01-27 22:26 ` Dmitry Osipenko
2021-01-27 21:52 ` [PATCH v5 00/21] support option where all commands are collected into a single,dedicated cmdstream Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFoeZGptRcu6sism@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=bhuntsman@nvidia.com \
--cc=cyndis@kapsi.fi \
--cc=daniel@ffwll.ch \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=talho@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox