* [PATCH] drm/tegra: Fix compilation of variadic macro
@ 2021-07-16 12:46 Jon Hunter
2021-07-16 13:01 ` Mikko Perttunen
2021-07-16 23:22 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Jon Hunter @ 2021-07-16 12:46 UTC (permalink / raw)
To: Thierry Reding, David Airlie, Daniel Vetter, Jonathan Hunter,
Mikko Perttunen, Naresh Kamboju
Cc: dri-devel, linux-tegra, Linux Kernel Functional Testing
Commit 43636451db8c ("drm/tegra: Implement job submission part of new
UAPI") added the macro 'SUBMIT_ERR' that in turns makes use of the macro
'__VA_OPT__'. The '__VA_OPT__' macro is not supported by older versions
of GCC and so causes build failures when using older versions of GCC.
Fix this by using the '##__VA_ARGS__' macro instead.
Fixes: 43636451db8c ("drm/tegra: Implement job submission part of new UAPI")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
drivers/gpu/drm/tegra/submit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
index c53b7207c478..e49630089149 100644
--- a/drivers/gpu/drm/tegra/submit.c
+++ b/drivers/gpu/drm/tegra/submit.c
@@ -24,7 +24,7 @@
#define SUBMIT_ERR(context, fmt, ...) \
dev_err_ratelimited(context->client->base.dev, \
"%s: job submission failed: " fmt "\n", \
- current->comm __VA_OPT__(,) __VA_ARGS__)
+ current->comm, ##__VA_ARGS__)
static struct tegra_drm_mapping *
tegra_drm_mapping_get(struct tegra_drm_context *context, u32 id)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/tegra: Fix compilation of variadic macro
2021-07-16 12:46 [PATCH] drm/tegra: Fix compilation of variadic macro Jon Hunter
@ 2021-07-16 13:01 ` Mikko Perttunen
2021-07-16 23:22 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Mikko Perttunen @ 2021-07-16 13:01 UTC (permalink / raw)
To: Jon Hunter, Thierry Reding, David Airlie, Daniel Vetter,
Mikko Perttunen, Naresh Kamboju
Cc: dri-devel, linux-tegra, Linux Kernel Functional Testing
On 7/16/21 3:46 PM, Jon Hunter wrote:
> Commit 43636451db8c ("drm/tegra: Implement job submission part of new
> UAPI") added the macro 'SUBMIT_ERR' that in turns makes use of the macro
> '__VA_OPT__'. The '__VA_OPT__' macro is not supported by older versions
> of GCC and so causes build failures when using older versions of GCC.
> Fix this by using the '##__VA_ARGS__' macro instead.
>
> Fixes: 43636451db8c ("drm/tegra: Implement job submission part of new UAPI")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/gpu/drm/tegra/submit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
> index c53b7207c478..e49630089149 100644
> --- a/drivers/gpu/drm/tegra/submit.c
> +++ b/drivers/gpu/drm/tegra/submit.c
> @@ -24,7 +24,7 @@
> #define SUBMIT_ERR(context, fmt, ...) \
> dev_err_ratelimited(context->client->base.dev, \
> "%s: job submission failed: " fmt "\n", \
> - current->comm __VA_OPT__(,) __VA_ARGS__)
> + current->comm, ##__VA_ARGS__)
>
> static struct tegra_drm_mapping *
> tegra_drm_mapping_get(struct tegra_drm_context *context, u32 id)
>
Thanks for taking care of this.
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/tegra: Fix compilation of variadic macro
2021-07-16 12:46 [PATCH] drm/tegra: Fix compilation of variadic macro Jon Hunter
2021-07-16 13:01 ` Mikko Perttunen
@ 2021-07-16 23:22 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2021-07-16 23:22 UTC (permalink / raw)
To: Jon Hunter
Cc: David Airlie, Daniel Vetter, Mikko Perttunen, Naresh Kamboju,
dri-devel, linux-tegra, Linux Kernel Functional Testing
[-- Attachment #1: Type: text/plain, Size: 746 bytes --]
On Fri, Jul 16, 2021 at 01:46:00PM +0100, Jon Hunter wrote:
> Commit 43636451db8c ("drm/tegra: Implement job submission part of new
> UAPI") added the macro 'SUBMIT_ERR' that in turns makes use of the macro
> '__VA_OPT__'. The '__VA_OPT__' macro is not supported by older versions
> of GCC and so causes build failures when using older versions of GCC.
> Fix this by using the '##__VA_ARGS__' macro instead.
>
> Fixes: 43636451db8c ("drm/tegra: Implement job submission part of new UAPI")
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/gpu/drm/tegra/submit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-16 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-16 12:46 [PATCH] drm/tegra: Fix compilation of variadic macro Jon Hunter
2021-07-16 13:01 ` Mikko Perttunen
2021-07-16 23:22 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).