From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, JC Kuo <jckuo@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Yang Yingliang <yangyingliang@huawei.com>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v3] usb: xhci: tegra: mark PM functions as __maybe_unused
Date: Thu, 7 Oct 2021 19:55:18 +0200 [thread overview]
Message-ID: <YV80ht6e7rfK0cfx@orome.fritz.box> (raw)
In-Reply-To: <20211005112057.2700888-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]
On Tue, Oct 05, 2021 at 01:20:28PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The added #ifdefs in the PM rework were almost correct, but still
> cause warnings in some randconfig builds:
>
> drivers/usb/host/xhci-tegra.c:2147:12: error: 'tegra_xusb_resume' defined but not used [-Werror=unused-function]
> 2147 | static int tegra_xusb_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~
> drivers/usb/host/xhci-tegra.c:2105:12: error: 'tegra_xusb_suspend' defined but not used [-Werror=unused-function]
> 2105 | static int tegra_xusb_suspend(struct device *dev)
>
> Replace the #ifdef checks with simpler __maybe_unused annotations to
> reliably shut up these warnings.
>
> Fixes: 971ee247060d ("usb: xhci: tegra: Enable ELPG for runtime/system PM")
> Reviewed-by: JC Kuo <jckuo@nvidia.com>
> Link: https://lore.kernel.org/all/20210421135613.3560777-2-arnd@kernel.org/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v3: fix reference to original commit.
> ---
> drivers/usb/host/xhci-tegra.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-10-07 17:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 11:20 [PATCH] [v3] usb: xhci: tegra: mark PM functions as __maybe_unused Arnd Bergmann
2021-10-07 17:55 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV80ht6e7rfK0cfx@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox