From: Mark Brown <broonie@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
lgirdwood@gmail.com, tiwai@suse.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, alsa-devel@alsa-project.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/10] ASoC: tegra: Fix kcontrol put callback in ADMAIF
Date: Mon, 8 Nov 2021 16:16:03 +0000 [thread overview]
Message-ID: <YYlNQya+YVg1JCRq@sirena.org.uk> (raw)
In-Reply-To: <d27bf513-6f16-5ad6-59cb-79fad5cc951c@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Mon, Nov 08, 2021 at 09:33:25PM +0530, Sameer Pujar wrote:
> With separate callbacks, the string checks can be removed. However for most
> of the controls, the common part is minimal. So there would be multiple
> independent small functions depending on the number of controls and the
> local variables are duplicated that many times. Would there be any concern
> on the space these local variables take? One pair of callbacks for a control
> may look like this.
...
> Looks like having separate callbacks make it look more cleaner. If this
> appears fine, I can send next revision.
Looks fine. It'll result in more code but hopefully they should be
smaller, especially if you're using substrings rather than the full
control name to identify the control and we need to store all them
separately to the copy used to identify the control to userspace (I
didn't go check).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-11-08 16:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 13:52 [PATCH v2 00/10] Fix kcontrol put callback in Tegra drivers Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 01/10] ASoC: tegra: Fix kcontrol put callback in ADMAIF Sameer Pujar
2021-11-03 14:16 ` Takashi Iwai
2021-11-03 14:18 ` Takashi Iwai
2021-11-03 17:25 ` Jaroslav Kysela
2021-11-08 16:03 ` Sameer Pujar
2021-11-08 16:16 ` Mark Brown [this message]
2021-11-08 16:08 ` Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 02/10] ASoC: tegra: Fix kcontrol put callback in I2S Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 03/10] ASoC: tegra: Fix kcontrol put callback in DMIC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 04/10] ASoC: tegra: Fix kcontrol put callback in DSPK Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 05/10] ASoC: tegra: Fix kcontrol put callback in AHUB Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 06/10] ASoC: tegra: Fix kcontrol put callback in MVC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 07/10] ASoC: tegra: Fix kcontrol put callback in SFC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 08/10] ASoC: tegra: Fix kcontrol put callback in AMX Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 09/10] ASoC: tegra: Fix kcontrol put callback in ADX Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 10/10] ASoC: tegra: Fix kcontrol put callback in Mixer Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYlNQya+YVg1JCRq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox