From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240BEC433EF for ; Thu, 25 Nov 2021 09:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350882AbhKYJhS (ORCPT ); Thu, 25 Nov 2021 04:37:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:33760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353894AbhKYJfS (ORCPT ); Thu, 25 Nov 2021 04:35:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 563B76108B; Thu, 25 Nov 2021 09:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637832727; bh=uvwK6xkBqc0Znk7K/Ky4+OAVTT2Tgux5Kci1XFX8G7s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A22aw7jpeZpx4drvuc79ExTAHz6VeHUzufIvszz7ZaVx6vozqrYdGuHHB4ir0DkuK 4DosN3et1ryeH2sSo99GI46FHAMGrBjfPt0qtOD8B9VjSAsNRfJ1lLuEMyJyhlHoGv DiaytizYSHxweQu8nu9uC6rol+SgVSBSEjRjgUudS+4ouGtjQrdd8dEfOOvDI0M0tk Lwu8GSBC4nwXXs69WFKA9Kb21m1eFmHQxaZcig1TBhzh82FgRakL2sHa7/Okr2+Wwy DmKF7mojkI+nVpmahE4/oqR+93nJWRLIZT+N2quZ9UqaNezklRPtuBCcngVQgzq7Oj 3e7fssOTS3ObQ== Date: Thu, 25 Nov 2021 15:02:02 +0530 From: Vinod Koul To: Arnd Bergmann Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, ALSA Development Mailing List , dri-devel , Bjorn Andersson , "open list:TEGRA ARCHITECTURE SUPPORT" , Thierry Reding , linux-mtd , Laurent Pinchart , linux-spi , Robert Jarzmik Subject: Re: [PATCH 07/11] dmaengine: qcom-adm: stop abusing slave_id config Message-ID: References: <20211115085403.360194-8-arnd@kernel.org> <202111251538.x6sJNCka-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 25-11-21, 09:25, Arnd Bergmann wrote: > On Thu, Nov 25, 2021 at 8:57 AM kernel test robot wrote: > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/dma/qcom/qcom_adm.c:712:18: warning: no previous prototype for function 'adm_dma_xlate' [-Wmissing-prototypes] > > struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > > ^ > > drivers/dma/qcom/qcom_adm.c:712:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > > struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > > ^ > > static > > 1 warning generated. > > I noticed this mistake slipped into v2 as well, the function needs to > be marked 'static'. > > Vinod, let me know how you want me to address this. Should I just fold > the fix (see below) > and the final Acks into the patch and send an updated pull request, or > do a complete v3 > submission? I can fold this while applying, the series lgtm, I will wait a day before applying... Thanks > > Arnd > > 8<--- > diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c > index bb338b303af6..65697bee4db0 100644 > --- a/drivers/dma/qcom/qcom_adm.c > +++ b/drivers/dma/qcom/qcom_adm.c > @@ -709,8 +709,8 @@ static void adm_channel_init(struct adm_device > *adev, struct adm_chan *achan, > * > * Returns pointer to appropriate dma channel on success or NULL on error. > */ > -struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > - struct of_dma *ofdma) > +static struct dma_chan *adm_dma_xlate(struct of_phandle_args *dma_spec, > + struct of_dma *ofdma) > { > struct dma_device *dev = ofdma->of_dma_data; > struct dma_chan *chan, *candidate = NULL; -- ~Vinod