From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 04/25] ARM: tegra: Rename top-level clocks
Date: Fri, 10 Dec 2021 13:53:07 +0100 [thread overview]
Message-ID: <YbNNs+H05YZxA2ex@orome> (raw)
In-Reply-To: <d545f269-7d99-f126-0ace-b1a5cffe3ab2@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]
On Thu, Dec 09, 2021 at 09:27:01PM +0300, Dmitry Osipenko wrote:
> 09.12.2021 20:33, Thierry Reding пишет:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Clocks defined at the top level in device tree are no longer part of a
> > simple bus and therefore don't have a reg property. Nodes without a reg
> > property shouldn't have a unit-address either, so drop the unit address
> > from the node names. To ensure nodes aren't duplicated (in which case
> > they would end up merged in the final DTB), append the name of the clock
> > to the node name.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > arch/arm/boot/dts/tegra114-dalmore.dts | 2 +-
> > arch/arm/boot/dts/tegra114-roth.dts | 2 +-
> > arch/arm/boot/dts/tegra114-tn7.dts | 2 +-
> > arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 +-
> > arch/arm/boot/dts/tegra124-nyan.dtsi | 2 +-
> > arch/arm/boot/dts/tegra124-venice2.dts | 2 +-
> > arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 4 ++--
> > arch/arm/boot/dts/tegra20-harmony.dts | 2 +-
> > arch/arm/boot/dts/tegra20-paz00.dts | 2 +-
> > arch/arm/boot/dts/tegra20-seaboard.dts | 2 +-
> > arch/arm/boot/dts/tegra20-tamonten.dtsi | 2 +-
> > arch/arm/boot/dts/tegra20-trimslice.dts | 2 +-
> > arch/arm/boot/dts/tegra20-ventana.dts | 2 +-
> > arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 +-
> > arch/arm/boot/dts/tegra30-beaver.dts | 2 +-
> > arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
> > 16 files changed, 17 insertions(+), 17 deletions(-)
>
> This and the next patch duplicate the preexisting patch [1] that you saw
> and skipped previously. It looks odd that you redoing it on your own
> now. This is not okay to me unless you talked to David and he is aware
> about it.
I had completely forgotten about it. I'll substitute David's authorship
for mine, but I'd prefer to keep the two changes in separate patches.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-10 12:53 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 17:33 [PATCH 00/25] ARM: tegra: Various cleanups for DT validation Thierry Reding
2021-12-09 17:33 ` [PATCH 01/25] ARM: tegra: Clean up external memory controller nodes Thierry Reding
2021-12-09 20:01 ` Dmitry Osipenko
2021-12-10 12:17 ` Thierry Reding
2021-12-10 15:15 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 02/25] ARM: tegra: Specify correct PMIC compatible on Tegra114 boards Thierry Reding
2021-12-09 17:33 ` [PATCH 03/25] ARM: tegra: Rename SPI flash chip nodes Thierry Reding
2021-12-09 17:33 ` [PATCH 04/25] ARM: tegra: Rename top-level clocks Thierry Reding
2021-12-09 18:27 ` Dmitry Osipenko
2021-12-10 12:53 ` Thierry Reding [this message]
2021-12-11 16:45 ` Dmitry Osipenko
2021-12-13 16:02 ` Thierry Reding
2021-12-13 16:52 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 05/25] ARM: tegra: Rename top-level regulators Thierry Reding
2021-12-09 17:33 ` [PATCH 06/25] ARM: tegra: Fix compatible string for Tegra30+ timer Thierry Reding
2021-12-09 19:36 ` Dmitry Osipenko
2021-12-10 13:42 ` Thierry Reding
2021-12-10 15:23 ` Dmitry Osipenko
2021-12-13 16:04 ` Thierry Reding
2021-12-13 16:44 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 07/25] ARM: tegra: Add #reset-cells for Tegra114 MC Thierry Reding
2021-12-09 20:34 ` Dmitry Osipenko
2021-12-10 13:43 ` Thierry Reding
2021-12-10 15:28 ` Dmitry Osipenko
2021-12-13 16:06 ` Thierry Reding
2021-12-13 16:47 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 08/25] ARM: tegra: Rename GPIO hog nodes to match schema Thierry Reding
2021-12-09 17:33 ` [PATCH 09/25] ARM: tegra: Rename GPU node on Tegra124 Thierry Reding
2021-12-09 17:33 ` [PATCH 10/25] ARM: tegra: Drop reg-shift for Tegra HS UART Thierry Reding
2021-12-09 19:01 ` Dmitry Osipenko
2021-12-10 13:49 ` Thierry Reding
2021-12-09 17:33 ` [PATCH 11/25] ARM: tegra: Rename thermal zone nodes Thierry Reding
2021-12-09 20:06 ` Dmitry Osipenko
2021-12-10 14:10 ` Thierry Reding
2021-12-10 15:29 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 12/25] ARM: tegra: Do not use unit-address for OPP nodes Thierry Reding
2021-12-09 18:38 ` Dmitry Osipenko
2021-12-10 14:27 ` Thierry Reding
2021-12-10 15:33 ` Dmitry Osipenko
2021-12-10 22:39 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 13/25] ARM: tegra: Fix Tegra124 I2C compatible string list Thierry Reding
2021-12-09 17:33 ` [PATCH 14/25] ARM: tegra: Drop unused AHCI clocks on Tegra124 Thierry Reding
2021-12-09 17:33 ` [PATCH 15/25] ARM: tegra: Sort Tegra124 XUSB clocks correctly Thierry Reding
2021-12-09 17:33 ` [PATCH 16/25] ARM: tegra: Avoid pwm- prefix in pinmux nodes Thierry Reding
2021-12-09 19:13 ` Dmitry Osipenko
2021-12-10 14:38 ` Thierry Reding
2021-12-10 15:38 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 17/25] ARM: tegra: Add compatible string for built-in ASIX on Colibri boards Thierry Reding
2021-12-09 17:33 ` [PATCH 18/25] ARM: tegra: Remove PHY reset GPIO references from USB controller node Thierry Reding
2021-12-09 17:33 ` [PATCH 19/25] ARM: tegra: Add dummy backlight power supplies Thierry Reding
2021-12-09 19:07 ` Dmitry Osipenko
2021-12-10 14:51 ` Thierry Reding
2021-12-09 17:33 ` [PATCH 20/25] ARM: tegra: Use correct vendor prefix for Invensense Thierry Reding
2021-12-09 17:33 ` [PATCH 21/25] ARM: tegra: Remove unsupported properties on Apalis Thierry Reding
2021-12-09 17:33 ` [PATCH 22/25] ARM: tegra: Move I2C clock frequency to bus nodes Thierry Reding
2021-12-09 18:57 ` Dmitry Osipenko
2021-12-10 15:01 ` Thierry Reding
2021-12-10 16:08 ` Dmitry Osipenko
2021-12-13 16:10 ` Thierry Reding
2021-12-13 16:34 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 23/25] ARM: tegra: Remove stray #reset-cells property Thierry Reding
2021-12-09 19:24 ` Dmitry Osipenko
2021-12-10 15:05 ` Thierry Reding
2021-12-10 18:08 ` Dmitry Osipenko
2021-12-13 16:11 ` Thierry Reding
2021-12-13 16:26 ` Dmitry Osipenko
2021-12-13 16:40 ` Dmitry Osipenko
2021-12-09 20:30 ` Dmitry Osipenko
2021-12-09 17:33 ` [PATCH 24/25] ARM: tegra: Fix SLINK compatible string on Tegra30 Thierry Reding
2021-12-09 17:33 ` [PATCH 25/25] ARM: tegra: Fix I2C mux reset GPIO reference on Cardhu Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbNNs+H05YZxA2ex@orome \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox