Re: [PATCH 04/25] ARM: tegra: Rename top-level clocks

Dmitry Osipenko
2021-12-13T16:52:44Z

13.12.2021 19:02, Thierry Reding пишет:
> On Sat, Dec 11, 2021 at 07:45:11PM +0300, Dmitry Osipenko wrote:
>> 10.12.2021 15:53, Thierry Reding пишет:
>>> On Thu, Dec 09, 2021 at 09:27:01PM +0300, Dmitry Osipenko wrote:
>>>> 09.12.2021 20:33, Thierry Reding пишет:
>>>>> From: Thierry Reding <treding@nvidia.com>
>>>>>
>>>>> Clocks defined at the top level in device tree are no longer part of a
>>>>> simple bus and therefore don't have a reg property. Nodes without a reg
>>>>> property shouldn't have a unit-address either, so drop the unit address
>>>>> from the node names. To ensure nodes aren't duplicated (in which case
>>>>> they would end up merged in the final DTB), append the name of the clock
>>>>> to the node name.
>>>>>
>>>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>>>>> ---
>>>>> arch/arm/boot/dts/tegra114-dalmore.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra114-roth.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra114-tn7.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra124-nyan.dtsi | 2 +-
>>>>> arch/arm/boot/dts/tegra124-venice2.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 4 ++--
>>>>> arch/arm/boot/dts/tegra20-harmony.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra20-paz00.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra20-seaboard.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra20-tamonten.dtsi | 2 +-
>>>>> arch/arm/boot/dts/tegra20-trimslice.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra20-ventana.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi | 2 +-
>>>>> arch/arm/boot/dts/tegra30-beaver.dts | 2 +-
>>>>> arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
>>>>> 16 files changed, 17 insertions(+), 17 deletions(-)
>>>>
>>>> This and the next patch duplicate the preexisting patch [1] that you saw
>>>> and skipped previously. It looks odd that you redoing it on your own
>>>> now. This is not okay to me unless you talked to David and he is aware
>>>> about it.
>>>
>>> I had completely forgotten about it. I'll substitute David's authorship
>>> for mine, but I'd prefer to keep the two changes in separate patches.
>>
>> I'll better separate David's patch and give you credit for that. David's
>> patch was well tested and improved over couple months in grate kernel,
>> while yours not.
>
> It's pretty much the same thing. There are slight differences in the
> names, but other than that there should be no functional difference.

Sure, but instead of guessing whether there is any functional difference
or not, let's simply use the version that was not only create earlier,
but also tested much wider.

Once again, I already took care about it. All the patches are in yours
email inbox. If there is a need for more coordination, then please ping
me on the IRC.