Re: [PATCH 11/25] ARM: tegra: Rename thermal zone nodes

Dmitry Osipenko
2021-12-10T15:29:33Z

10.12.2021 17:10, Thierry Reding пишет:
> On Thu, Dec 09, 2021 at 11:06:30PM +0300, Dmitry Osipenko wrote:
>> 09.12.2021 20:33, Thierry Reding пишет:
>>> From: Thierry Reding <treding@nvidia.com>
>>>
>>> The DT schema requires that nodes representing thermal zones include a
>>> "-thermal" suffix in their name.
>>>
>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>>> ---
>>> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 6 +++---
>>> arch/arm/boot/dts/tegra124-apalis.dtsi | 6 +++---
>>> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 6 +++---
>>> arch/arm/boot/dts/tegra124.dtsi | 8 ++++----
>>> 4 files changed, 13 insertions(+), 13 deletions(-)
>>
>> Won't this break the soctherm driver? Looks like it relies on those
>> names. Have you tested this?
>
> No, as far as I can tell this is matched based on the sensor ID. The
> name that is specified in the driver is only used in kernel messages
> but has no impact on how the nodes are matched, so this patch should
> have no impact on functionality at all.
>
> I've just tested this on Jetson TK1 and indeed all of the thermal
> zones are still properly accounted for:
>
> # ls /sys/class/thermal/thermal_zone*
> /sys/class/thermal/thermal_zone0:
> available_policies k_d offset sustainable_power trip_point_1_hyst
> cdev0 k_i policy temp trip_point_1_temp
> cdev0_trip_point k_po power trip_point_0_hyst trip_point_1_type
> cdev0_weight k_pu slope trip_point_0_temp type
> integral_cutoff mode subsystem trip_point_0_type uevent
>
> /sys/class/thermal/thermal_zone1:
> available_policies k_pu slope trip_point_0_temp type
> integral_cutoff mode subsystem trip_point_0_type uevent
> k_d offset sustainable_power trip_point_1_hyst
> k_i policy temp trip_point_1_temp
> k_po power trip_point_0_hyst trip_point_1_type
>
> /sys/class/thermal/thermal_zone2:
> available_policies k_d offset sustainable_power trip_point_1_hyst
> cdev0 k_i policy temp trip_point_1_temp
> cdev0_trip_point k_po power trip_point_0_hyst trip_point_1_type
> cdev0_weight k_pu slope trip_point_0_temp type
> integral_cutoff mode subsystem trip_point_0_type uevent
>
> /sys/class/thermal/thermal_zone3:
> available_policies k_pu slope trip_point_0_temp type
> integral_cutoff mode subsystem trip_point_0_type uevent
> k_d offset sustainable_power trip_point_1_hyst
> k_i policy temp trip_point_1_temp
> k_po power trip_point_0_hyst trip_point_1_type
>
> The only difference, as far as I can tell, is that the "type" attribute
> now reflects the new name, but that seems harmless enough.

Alright