Re: [PATCH 01/25] ARM: tegra: Clean up external memory controller nodes

Dmitry Osipenko
2021-12-09T20:01:14Z

09.12.2021 20:33, Thierry Reding пишет:
> From: Thierry Reding <treding@nvidia.com>
>
> The external memory controller should be sorted after the memory
> controller to keep the ordering by unit-address intact.

"sorted after the memory controller, I don't understand what this means.
Please clarify.

> While at it,
> rename the emc-timings and timing nodes to avoid including the RAM code
> and clock frequency in their names. There is no requirement to do this,
> so we can use simple enumerations instead.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 483 +++--
> .../arm/boot/dts/tegra124-jetson-tk1-emc.dtsi | 699 +++---
> arch/arm/boot/dts/tegra124-nyan-big-emc.dtsi | 1918 +++++++++--------
> .../arm/boot/dts/tegra124-nyan-blaze-emc.dtsi | 639 +++---
> 4 files changed, 1900 insertions(+), 1839 deletions(-)

It's very suspicious that you changed only T124. This all doesn't look
good to me.

Please either explain it all or drop this patch.