Re: [PATCH v4 3/3] i2c: smbus: Use device_*() functions instead of of_*()

Wolfram Sang
2022-01-27T21:57:33Z

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi,

> + irq = device_property_match_string(adapter->dev.parent, "interrupt-names",
> + "smbus_alert");

I think we should include "linux/property.h" for it. Interesting, the of
header was never included.

> - irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert");
> + irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
> + "smbus_alert");

Here we should replace of_irq.h with property.h.

Rest looks good!

Happy hacking,

Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]