Re: [PATCH v4 0/3] Enable named interrupt smbus-alert for ACPI

Rafael J. Wysocki
2022-01-24T18:52:34Z

On Sat, Jan 22, 2022 at 1:06 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Sat, Jan 22, 2022 at 1:33 PM Akhil R <akhilrajeev@nvidia.com> wrote:
> >
> > I2C - SMBus core drivers use named interrupts to support smbus_alert.
> > As named interrupts are not available for ACPI based systems, it was
> > required to change the i2c bus controller driver if to use smbus alert.
> > These patches provide option for named interrupts in ACPI and make the
> > implementation similar to DT. This will enable use of interrupt named
> > 'smbus-alert' in ACPI as well which will be taken during i2c adapter
> > register.
>
> I'm fine with the series,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Maintainers can ask something else, though.

It looks good to me.

If no one else has concerns regarding it, I'll queue it up for 5.18.

> > v3->v4:
> > * Removed device_irq_get_byname()
> > * Updates in comments and document.
> > v2->v3:
> > * Grammar/spelling corrections.
> > * Added description in function comments.
> > * Removed 'unlikely' from NULL check on 'name'
> > v1->v2:
> > * Added firmware guide documentation for ACPI named interrupts
> > * Updates in function description comments
> >
> > Akhil R (3):
> > device property: Add fwnode_irq_get_byname
> > docs: firmware-guide: ACPI: Add named interrupt doc
> > i2c: smbus: Use device_*() functions instead of of_*()
> >
> > Documentation/firmware-guide/acpi/enumeration.rst | 39 +++++++++++++++++++++++
> > drivers/base/property.c | 29 +++++++++++++++++
> > drivers/i2c/i2c-core-base.c | 2 +-
> > drivers/i2c/i2c-core-smbus.c | 10 +++---
> > drivers/i2c/i2c-smbus.c | 3 +-
> > include/linux/i2c-smbus.h | 6 ++--
> > include/linux/property.h | 1 +
> > 7 files changed, 80 insertions(+), 10 deletions(-)
> >
> > --
> > 2.7.4
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko